Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate gutenberg-mobile release 1.46.1 to 1.47.0 #15905

Merged
merged 15 commits into from
Feb 18, 2021
Merged

Integrate gutenberg-mobile release 1.46.1 to 1.47.0 #15905

merged 15 commits into from
Feb 18, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Feb 17, 2021 •
edited
Loading

This PR incorporates the changes from 1.46.1 release of gutenberg-mobile to 1.47.0 release.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 17, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 42425. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@fluiddot fluiddot added the Gutenberg Editing and display of Gutenberg blocks. label Feb 17, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 17, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

fluiddot and others added 4 commits February 17, 2021 13:34
@dcalhoun dcalhoun mentioned this pull request Feb 17, 2021
Merged
3 tasks
@fluiddot fluiddot marked this pull request as ready for review February 18, 2021 08:14
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 18, 2021 •
edited
Loading

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

antonis
antonis approved these changes Feb 18, 2021
View reviewed changes
Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @fluiddot 👍
Tested the build 42425 from AppCenter with a quick walkthrough on an iPhone SE 2020 (iOS 14.2). Also validated the Audioblock availability on non-free sites.
The code changes LGTM 🎉

@fluiddot fluiddot merged commit 64616c7 into gutenberg/integrate_release_1.47.0 Feb 18, 2021
@fluiddot fluiddot deleted the gutenberg/integrate_release_1.46.1_to_1.47.0 branch February 18, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

@ceyhun ceyhun Awaiting requested review from ceyhun

@dcalhoun dcalhoun Awaiting requested review from dcalhoun

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fluiddot @antonis @ceyhun @jd-alexander @dcalhoun