Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.47.0 #3155

Merged
merged 70 commits into from
Feb 19, 2021
Merged

Release 1.47.0 #3155

merged 70 commits into from
Feb 19, 2021

Conversation

antonis
Copy link

@antonis antonis commented Feb 16, 2021 •
edited by dcalhoun
Loading

Release for Gutenberg Mobile 1.47.0

Related PRs

Extra PRs that Landed After the Release Was Cut

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.

Release Submission Checklist

  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

AmandaRiu and others added 30 commits January 29, 2021 18:43
@AmandaRiu
Update gutenberg reference and add release notes
a9218c7
@AmandaRiu
Add PR link to release notes
899196a
@AmandaRiu
Update reference to gutenberg
d1ae657
@jd-alexander
updated gutenberg ref.
5eef0c1
@jd-alexander
Update gutenberg ref.
15c4e04
@jd-alexander
Updated the gutenberg ref.
7423a9e
@jd-alexander
Merge branch 'develop' into add/audio-block-ui-test
eb61dbd 
Removed submodule gutenberg
@jd-alexander
Updated ref.
b5d6872
@jd-alexander
Updated gutenberg ref
8bafdd8
@jd-alexander
Updated ref.
127bac8
@bjtitus
Temporary gutenberg update to test media files type
1550a22
@jd-alexander
Merge branch 'develop' into add/audio-block-ui-test
92df124
@jd-alexander
updated ref.
f6591b8
@jd-alexander
Updated gutenberg ref.
c78ae39
@jd-alexander
Merge branch 'develop' into fix/ui-tests-expect-fix
9253329
@jd-alexander
updated gutenberg ref.
028666b
@jd-alexander
Merge pull request #3091 from wordpress-mobile/add/audio-block-ui-test
4711aec 
Audio block UI test
@jd-alexander
Merge branch 'develop' into fix/ui-tests-expect-fix
a14f554
@jd-alexander
Updated gutenberg ref.
36dc0c3
@jd-alexander
updated gutenberg ref.
ff29e56
@jd-alexander
Merge pull request #3110 from wordpress-mobile/fix/ui-tests-expect-fix
f4b5931 
Invert the expect matcher values of the e2e tests
@dratwas
JS Performance improvements (#3088)
c15379e 
* update ref and add needed babel plugin
@bjtitus
Update to latest gutenberg
65e0e25
@bjtitus
Merge branch 'develop' into stories/mediaFiles-type
dcacde7
@illusaen
WC: Adding contact info toggle that depends on capabilities.
93fcfa7
@mzorz @illusaen
udpated gutenberg commit hash to use the new contact info block flag …
5b195c0 
…on the bridge
@jd-alexander @illusaen
updated bundle.
fcf8cf5
@illusaen
Updating PR to only deal with the feature toggle and jetpack api vers…
cbf8241 
…ions; splitting out dev flag removal for later PR.
@fluiddot
Update appium to version 1.20.2
cb0b690
@fluiddot
Update gutenberg ref
90600cb
@dcalhoun
Copy link
Member

dcalhoun commented Feb 16, 2021 •
edited
Loading

🟡 Android: Writing Flow checklist

General

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@dcalhoun
Copy link
Member

dcalhoun commented Feb 16, 2021 •
edited
Loading

Summary: Manual Tests Round 1

Regressions in Release

Preexisting Bugs

@fluiddot
Merge branch 'release/1.47.0' into merge_release_1.46.1_to_1.47.0
9db5b81 
# Conflicts:
#	bundle/ios/App.js
#	bundle/ios/App.js.map
#	gutenberg
#	package-lock.json
#	package.json
@fluiddot
Update gutenberg ref
0474224
@fluiddot
Update bundle
3032fd3
@geriux geriux mentioned this pull request Feb 17, 2021
Merged
7 tasks
@dcalhoun
Copy link
Member

dcalhoun commented Feb 17, 2021 •
edited
Loading

🟢 Android: Writing Flow checklist (round 2)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@dcalhoun
Copy link
Member

dcalhoun commented Feb 17, 2021 •
edited
Loading

🟢 iOS Writing Flow checklist (round 2)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@dcalhoun dcalhoun mentioned this pull request Feb 17, 2021
Closed
@antonis
Copy link
Author

antonis commented Feb 18, 2021 •
edited
Loading

🟢Android Sanity Tests (Test Suite 4) - round 2

  • Test device: Google Pixel 2 XL (Android 11)
  • Build from PR

DarkMode - 2

  • Spacer block - Dark mode - TC004
  • Buttons block - Dark mode - TC005
  • Group - Dark mode - TC006
  • Columns - Dark mode - TC007

Group - 2

  • Group - Navigation up button works as expected - TC009
  • Group - Navigation down works according to parent-first approach - TC010
  • Group - Cross navigation between blocks works as expected - TC011
  • Group - Ungroup button works as expected - TC012
  • Group - Check if in DarkMode all components gets proper colors - TC013
  • Group - Check if nested Placeholder block can be replaced - TC014

Spacer - 2

  • Spacer block - Settings: Available height range is correct - TC004
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - TC005
  • Spacer block - Spacer in horizontal layout works as expected - TC006

Buttons - 4

  • Buttons block - Render custom text color - TC017
  • Buttons block - Render custom background color - TC016
  • Buttons block - Render gradient background color - TC018
  • Buttons block - Check if selection / caret color matches font color - TC020
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - TC021

Buttons - 5

  • Buttons block - Edit text styles - TC009
  • Buttons block - Render theme colors - TC019
  • Buttons block - Settings: Change Button border radius - TC015

Buttons - 7

  • Buttons block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - TC008
  • Buttons block - Toolbar link button is active when Button has link - TC022

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - TC004
  • Offline Support - TC005

Color Settings - 2

  • Pressing color swatch - TC004
  • Customize gradient color - TC005
  • Custom color picker - TC006

@geriux
Copy link
Member

geriux commented Feb 18, 2021 •
edited
Loading

🟢 iOS Sanity Tests - Test Suite 3

  • Device: iPhone 12 Pro
  • OS 14.4
  • Build 42460

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC004
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Gallery - 4

  • Gallery block - Settings: Link to - TC012
  • Gallery block - Settings: Column number - TC013
  • Gallery block - Settings: Crop images - TC014

MediaText - 3

  • Media Text block - Insert video from device (failing) - TC001-v
  • Media Text block - Close/Re-open post with an ongoing video upload - TC003-v

MediaText - 4

  • Media Text block - Media & Text alignment - TC006
  • Media Text block - Vertical alignment - TC007

Cover - 2

  • Cover - Add Video Background from WordPress Media library - TC005
  • Cover - Replace media - TC006
  • Cover - Gradient background is rendered properly - TC007
  • Cover - Gradient overlay is rendered properly - TC008

Social Icons - 2

  • The link sheet is opened automatically when adding new icon - TC004
  • Ghost placeholder is visible when no icon is active - TC005
  • Social icon forwarding to the link - TC006

Image - 2

  • Image block - Switch to classic editor with an image block in page - TC006
  • Image block - Border style setting - TC007
  • Image block - Image size setting - TC008
  • Image block - Link to setting - TC009

Story block - 1

Not available on iOS yet

@antonis
Copy link
Author

antonis commented Feb 18, 2021 •
edited
Loading

🟢 Android: Writing Flow checklist - round 3

  • Test device: Google Pixel 2 XL (Android 11)
  • Build from PR

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@dcalhoun
Copy link
Member

dcalhoun commented Feb 18, 2021 •
edited
Loading

🟢 iOS Writing Flow checklist (round 3)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@dcalhoun
Copy link
Member

dcalhoun commented Feb 18, 2021 •
edited
Loading

🟡 Summary: Manual Tests Round 3

@dcalhoun
Merge branch 'trunk' of github.com:wordpress-mobile/gutenberg-mobile …
4e1973b 
…into release/merge_release_1.46.2_to_1.47.0
@dcalhoun
Merge pull request #3176 from wordpress-mobile/release/merge_release_…
9c49571 
…1.46.2_to_1.47.0

Merge 1.46.2 beta fix release into 1.47.0
@antonis
Copy link
Author

antonis commented Feb 18, 2021

At this stage this LGTM 🎉

dcalhoun
dcalhoun approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We just need to decide on a strategy to fix/validate the frozen Gutenberg CI tests, then we are good to merge.

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun dcalhoun merged commit 14e5e96 into trunk Feb 19, 2021
@dcalhoun dcalhoun deleted the release/1.47.0 branch February 19, 2021 14:21
@dcalhoun dcalhoun mentioned this pull request Feb 19, 2021
Merged
2 tasks
@fluiddot fluiddot restored the release/1.47.0 branch March 9, 2021 09:56
@fluiddot fluiddot deleted the release/1.47.0 branch March 9, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet