Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate gutenberg-mobile release 1.62.0 #17183

Merged
merged 3 commits into from
Sep 20, 2021

Conversation

enejb
Copy link
Contributor

@enejb enejb commented Sep 17, 2021

Description

This PR incorporates the 1.62.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3984

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@enejb enejb added the Gutenberg Editing and display of Gutenberg blocks. label Sep 17, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 17, 2021

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 56752. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@jd-alexander jd-alexander marked this pull request as ready for review September 17, 2021 22:02
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@jd-alexander jd-alexander added this to the 18.3 milestone Sep 18, 2021
@enejb enejb merged commit 3c00715 into develop Sep 20, 2021
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve and merge this because I'm running the code freeze for 18.3 today and it would be handy if this the latest mobile-gutenberg stable was already on develop.

I feel comfortable approving this because this is only the version bump. The actual changes have already been tested here.

I'd rather ship the first beta and take onboard the limited risk of having to revert the version or merge a hotfix later because the payoff is that the other parts of the area will be available for testing and we can get ahead with those.

You might have noticed that there are CI failures, but they are all in the UI tests and due to an issue in the tests themselves (see #17177). I'm going to merge this PR first and #17177 after to make the conflict resolution on the Podfile* easier. If this PR introduced new genuine failures in UI tests, the #17177 merge into develop will reveal it to us 👍

@enejb enejb deleted the gutenberg/integrate_release_1.62.0 branch September 20, 2021 02:23
@jd-alexander
Copy link
Contributor

I feel comfortable approving this because this is only the version bump. The actual changes have already been tested here.

Appreciated @mokagio I was just about to do this merge! 😄 Thanks for handling it!

You might have noticed that there are CI failures, but they are all in the UI tests and due to an issue in the tests themselves (see #17177). I'm going to merge this PR first and #17177 after to make the conflict resolution on the Podfile* easier. If this PR introduced new genuine failures in UI tests, the #17177 merge into develop will reveal it to us 👍

Makes sense! I appreciate you creating that fix to resolve the UI test issues 🙇🏾

@mokagio
Copy link
Contributor

mokagio commented Sep 20, 2021

Followup on the UI tests. As you can see on the checks for this commit based on top of develop after this was merged, the UI tests are all green 😄

@jd-alexander
Copy link
Contributor

Followup on the UI tests. As you can see on the checks for this commit based on top of develop after this was merged, the UI tests are all green 😄

Great! Thanks for the update @mokagio :shipit:

@enejb
Copy link
Contributor Author

enejb commented Sep 20, 2021

Thanks for approving and fixing the UI tests! @mokagio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants