-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate gutenberg-mobile release 1.62.0 #17183
Conversation
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve and merge this because I'm running the code freeze for 18.3 today and it would be handy if this the latest mobile-gutenberg
stable was already on develop
.
I feel comfortable approving this because this is only the version bump. The actual changes have already been tested here.
I'd rather ship the first beta and take onboard the limited risk of having to revert the version or merge a hotfix later because the payoff is that the other parts of the area will be available for testing and we can get ahead with those.
You might have noticed that there are CI failures, but they are all in the UI tests and due to an issue in the tests themselves (see #17177). I'm going to merge this PR first and #17177 after to make the conflict resolution on the Podfile*
easier. If this PR introduced new genuine failures in UI tests, the #17177 merge into develop
will reveal it to us 👍
Appreciated @mokagio I was just about to do this merge! 😄 Thanks for handling it!
Makes sense! I appreciate you creating that fix to resolve the UI test issues 🙇🏾 |
Followup on the UI tests. As you can see on the checks for this commit based on top of |
Great! Thanks for the update @mokagio |
Thanks for approving and fixing the UI tests! @mokagio |
Description
This PR incorporates the 1.62.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3984
Release Submission Checklist
RELEASE-NOTES.txt
if necessary.