Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.62.0 #3984

Merged
merged 114 commits into from Sep 18, 2021
Merged

Release 1.62.0 #3984

merged 114 commits into from Sep 18, 2021

Conversation

enejb
Copy link
Contributor

@enejb enejb commented Sep 17, 2021

Release for Gutenberg Mobile 1.62.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Embed block: Enable WordPress embed preview

PR: #3853

Embed block: Add error bottom sheet with retry and convert to link actions.

PR: #3921

Embed block: Implemented the No Preview UI when an embed is successful, but we're unable to show an inline preview

PR: #3927

Embed block: Add device's locale to preview content

PR: #3788

Embed block: Fix content disappearing on Android when switching light/dark mode

PR: #3859

Column block: Translate column width's control labels

PR: #3952

Embed block: Enable embed preview for Instagram and Vimeo providers.

PR: #3918

Fix Android-only issue of main toolbar initial position being wrong when RTL

PR: #3923

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.
  • Test the Unsupported Block Editor on WP Apps (see steps).
  • Sanity test suites for WP Apps should be completed for each platform.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

fluiddot and others added 30 commits August 3, 2021 18:47
…e into bug/fix-query-controls-react-key-warning
…-react-key-warning

Fix various React warnings in development log
…o_develop

Merge release 1.61.0 to develop
[Embed block] Enable WordPress embed preview
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 17, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@enejb
Copy link
Contributor Author

enejb commented Sep 17, 2021

Tested on Pixel 5. (Android 11)

Writing Flow checklist

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@jd-alexander jd-alexander marked this pull request as ready for review September 17, 2021 22:02
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I smoke tested both the iOS and Android builds of this release and the editor functioned as expected.

@jd-alexander jd-alexander merged commit 7f53d96 into trunk Sep 18, 2021
@jd-alexander jd-alexander deleted the release/1.62.0 branch September 18, 2021 06:27
@geriux
Copy link
Member

geriux commented Sep 21, 2021

🟢 Sanity testing - Test suite 2 (Android)

Device: Redmi Note 8T (Android 10)
Build: 18.3-rc-1

DarkMode - 1

  • Gallery block - Dark mode - TC001
  • Shortcode block - Dark mode - TC002
  • Media Text block - Dark mode - TC003

Group - 1

  • Group - AppenderButton is rendered - TC001
  • Group - Deep nesting is possible (iOS only) - TC002
  • Group - Check if Group placeholder is visible for the unselected state - TC003
  • Group - Check if Group placeholder is render in nested structure - TC004
  • Group - Nested block have proper border styling - TC005
  • Group - Nested block have proper margins values - TC006
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - TC008

Spacer - 1

  • Spacer block - Spacer is rendered without crash - TC001
  • Spacer block - Settings: Control spacer height using the slider - TC002
  • Spacer block - Settings: Control spacer height using the text input - TC003

Buttons-1

  • Buttons block - Buttons block is added with focused Button with gray background color and white text color - TC001
  • Buttons block - Buttons inline appender - TC002
  • Buttons block - Add another Button inside Buttons using inserter - TC003
  • Buttons block - Button's wrapper grows properly - TC023

Buttons-2

  • Buttons block - Removing Button along with Buttons block - TC004
  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - TC005

Buttons-3

  • Buttons block - Wrapping Buttons - TC006
  • Buttons block - Buttons alignment options - TC007

Button-6

  • Buttons block - Settings: Open in new tab - TC011
  • Buttons block - Settings: Link rel - TC012
  • Buttons block - Settings: Link URL - TC010
  • Buttons block - Settings: Remove link - TC014
  • Buttons block - Settings: Synchronize with button options - TC013

Color Settings - 1

  • Colors Segmented Controls - TC001
  • Scroll color palette to start - TC002
  • Scroll color palette to the end - TC003

Image - 1

  • Image block - Insert image from device (failing) - TC001
  • Image block - Insert image from device (cancel) - TC002
  • Image block - Add Caption - TC003
  • Image block - Close/Re-open post with an ongoing image upload - TC004
  • Image block - Close post with an ongoing image upload - TC005
    ⚠️ All tests above passed but the image doesn't have the right size due to a regression, there's a fix already that will be available in the next beta fix.

@geriux
Copy link
Member

geriux commented Sep 21, 2021

🟢 Sanity testing - Story block 1 (Android)

Device: Redmi Note 8T (Android 10)
Build: 18.3-rc-1

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

@enejb
Copy link
Contributor Author

enejb commented Sep 21, 2021

Device: iPhone 11 Pro
Build: 18.3 (18.3.0.20210920)

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC04
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Columns - 1

  • Columns - Columns percentage mechanism - column's preview - TC019
  • Columns - Columns percentage mechanism - column's slider input - TC020
  • Columns - Columns percentage mechanism - predefined percentage values are rendered correctly on frontend- TC021
  • 🔴 Columns percentage mechanism - custom percentage values are rendered correctly on frontend- TC022
    if you select a percentage column width (and then you save it you end up with a problem displaying block)
  • Columns - Multiple slider in columns parent - TC023
  • Columns - Adding Column with AppenderButton - TC003
  • Columns - Adding and removing Column with BottomSheet Stepper control - TC004

Columns - 2

  • Columns - Max limit of Column number - TC005
  • Columns - Min limit of Column number - TC006
  • Columns - Removing Column with remove button - TC007
  • Columns - Removing the only one left Column with remove button - TC008
  • Columns - Changing alignment on Columns - TC009
  • Columns - Changing alignment on individual Column - TC010
  • Columns - Alignment attribute is properly passed when adding Column - TC011
  • Columns - Deep nesting is possible (iOS only)- TC012

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - TC002
  • Columns - Appearance in vertical device position (vertical layout) - TC013
  • Columns - Appearance in horizontal device position (horizontal layout) - TC014
  • Columns - Mover direction - TC015
  • Columns - Check if Column placeholder is render in nested structure - TC016
  • Columns - Unselected Column placeholder is stretched to content in nested structure- TC017

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

  • Media Text block - Insert video from device (TC002) - steps
  • Media Text block - Insert image from device (TC002) - steps

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Change Minimum height in pixels - TC002
  • Cover - Change Background Opacity - TC009
  • Cover - Image focal point is rendered properly - TC003
  • Cover - Custom color is rendered properly - TC004

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

  • The newly created Social Icons block is added with 4 icons - TC001
  • Active icon gets product color - TC002
  • Only active icons are visible when not selected - TC003

@jd-alexander
Copy link
Contributor

jd-alexander commented Sep 21, 2021

Release Notes Testing

Device: iPhone 11
Build: 18.3

@enejb
Copy link
Contributor Author

enejb commented Sep 21, 2021

Release Notes Testing

Device: Pixel 5 | Android 11
Build: 18.3-rc-1

@enejb
Copy link
Contributor Author

enejb commented Sep 21, 2021

Writing Flow Tests

Device: Pixel 5 | Android 11
Build: 18.3-rc-1

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block - spliting a list doesn't work as expected for me. After more testing this worked as expected and wasn't a regression.

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@enejb
Copy link
Contributor Author

enejb commented Sep 21, 2021

Unsupported Block Tests

Device: Pixel 5 | Android 11
Build: 18.3-rc-1

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • I end up with a white screen when trying to edit the unsupported block.
    • turned out this was not a regression. and things worked as expected for @guarani
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@jd-alexander
Copy link
Contributor

jd-alexander commented Sep 21, 2021

Writing Flow Tests

Device: iPhone 11
Build: 18.3

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@jd-alexander
Copy link
Contributor

jd-alexander commented Sep 21, 2021

Unsupported Block Tests

Device: iPhone 11
Build: 18.3

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants