Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for viewing trashed posts #23142

Merged
merged 5 commits into from
May 4, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented May 2, 2024

Fixes #6037 by allowing you to preview trashed posts and restore them right from the editor. This is now a much better experience than the production version where you tap on a trashed post and nothing happens. On Android, tapping on a trashed prompt, opens an alert to restore it. This is taking it a step further.

Testing

Test 1.1

Note: test for Posts, Pages and Search

  • Open a trashed post
  • ✅ Verify that navigation bar buttons are hidden
  • Tap anywhere in the UI or perform any other gesture like swip
  • ✅ Verify that the alert promting you to restore the post is shown
  • Tap "Restore"
  • ✅ Verify that the success notice was shown
  • ✅ Verify that the UI was reloaded and the navigation bar buttons appeared (matching "draft" state)
  • (Optional) Make and save changes to the post
  • ✅ Verify that the changes were saved

Test 1.2

  • Open a trashed post
  • Close the trashed post
  • Open the trashed post
  • ✅ Verify that no assertions were hit and nothing updated in the UI
Screen.Recording.2024-05-02.at.11.55.11.AM.mov

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 24.9 milestone May 2, 2024
@kean kean requested a review from momo-ozawa May 2, 2024 15:57
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 2, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23142-d9fdb34
Version24.8
Bundle IDorg.wordpress.alpha
Commitd9fdb34
App Center BuildWPiOS - One-Offs #9795
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 2, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23142-d9fdb34
Version24.8
Bundle IDcom.jetpack.alpha
Commitd9fdb34
App Center Buildjetpack-installable-builds #8841
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits

WordPress/Classes/ViewRelated/Post/PostEditor.swift Outdated Show resolved Hide resolved
@@ -432,6 +432,8 @@
0A9687BC28B40771009DCD2F /* FullScreenCommentReplyViewModelMock.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0A9687BB28B40771009DCD2F /* FullScreenCommentReplyViewModelMock.swift */; };
0C01A6EA2AB37F0F009F7145 /* SiteMediaCollectionCellSelectionOverlayView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0C01A6E92AB37F0F009F7145 /* SiteMediaCollectionCellSelectionOverlayView.swift */; };
0C01A6EB2AB37F0F009F7145 /* SiteMediaCollectionCellSelectionOverlayView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0C01A6E92AB37F0F009F7145 /* SiteMediaCollectionCellSelectionOverlayView.swift */; };
0C02E6C52BE3B6E30055F0F6 /* PostTrashedOverlayView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0C02E6C42BE3B6E30055F0F6 /* PostTrashedOverlayView.swift */; };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] rename to TrashedPostOverlayView.swift to match class name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I renamed the class itself to PostTrashedOverlayView – using Post as a namescape.

@kean kean force-pushed the task/restore-trashed-post-with-preview branch from c0ebc15 to bca05eb Compare May 4, 2024 12:16
@kean kean enabled auto-merge May 4, 2024 12:17
@kean kean merged commit e187759 into trunk May 4, 2024
24 checks passed
@kean kean deleted the task/restore-trashed-post-with-preview branch May 4, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Posts: Allow trashed posts to be previewed.
3 participants