Reader: Only reload filters when tab items change

[wargcm]

Description

There was an onChange causing the current selected filter to be reset. I updated it to only reset the active filter if the tab items actually change.

Testing

I used some test code to replicate the issue. Change:

WordPress-iOS/WordPress/Classes/ViewRelated/Reader/Tab Navigation/ReaderNavigationMenu.swift

Line 57 in 65bed38

viewModel.navigateToSearch()

To:

viewModel.fetchReaderMenu()

To test:

• Use the test code from above
• Launch Jetpack and login
• Navigate to the "Your Tags" feed
• Tap on the tags chip and select a tag to filter the feed
• Tap on the search icon
• 🔎 Verify the filter is not reset
• Repeat the above steps with the "Subscriptions" feed and the blog filter

Regression Notes

1. Potential unintended areas of impact
   Should be none.

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   N/A

3. What automated tests I added (or what prevented me from doing so)
   N/A
   PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23182-b8eccb4
	Version	24.8
	Bundle ID	com.jetpack.alpha
	Commit	b8eccb4
	App Center Build	jetpack-installable-builds #8911

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23182-b8eccb4
	Version	24.8
	Bundle ID	org.wordpress.alpha
	Commit	b8eccb4
	App Center Build	WPiOS - One-Offs #9863

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[dvdchr]

LGTM!

[dangermattic]

	1 Warning
⚠️	This PR is assigned to the milestone 24.9. This milestone is due in less than 4 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger