-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg] Voice to content #23234
[Gutenberg] Voice to content #23234
Conversation
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr23234-6448c18 | |
Version | 25.0 | |
Bundle ID | com.jetpack.alpha | |
Commit | 6448c18 | |
App Center Build | jetpack-installable-builds #9094 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr23234-6448c18 | |
Version | 25.0 | |
Bundle ID | org.wordpress.alpha | |
Commit | 6448c18 | |
App Center Build | WPiOS - One-Offs #10044 |
WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift
Outdated
Show resolved
Hide resolved
Tests fail because of the content added into the editor. Those should pass once we remove the hard-coded call to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @geriux! 🚀
Hey, @geriux. I've been testing, and it's been working great so far, but I found a couple of missing features:
|
Thank you for the feedback @kean! I'll take a look! |
➕ I should've called that out, but assumed it was expected in the test. I saw it on both Android and iOS. Thanks @kean. |
d42c779
to
6448c18
Compare
Related PRs:
To test:
A hard-coded call has been added to test the integration with the editor.
Regression Notes
It should only affect the Editor.
Manual testing
Integration tests were added in Gutenberg Mobile
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: