Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Voice to content #23234

Merged
merged 2 commits into from
May 31, 2024
Merged

[Gutenberg] Voice to content #23234

merged 2 commits into from
May 31, 2024

Conversation

geriux
Copy link
Member

@geriux geriux commented May 20, 2024

Related PRs:

To test:

A hard-coded call has been added to test the integration with the editor.

  • Install the build from this RP
  • Open the editor
  • Expect the content to be added once the editor opens.

Regression Notes

  1. Potential unintended areas of impact

It should only affect the Editor.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing

  1. What automated tests I added (or what prevented me from doing so)

Integration tests were added in Gutenberg Mobile

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@geriux geriux added [Status] DO NOT MERGE [Status] In Progress Gutenberg Editing and display of Gutenberg blocks. labels May 20, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 20, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23234-6448c18
Version25.0
Bundle IDcom.jetpack.alpha
Commit6448c18
App Center Buildjetpack-installable-builds #9094
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 20, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23234-6448c18
Version25.0
Bundle IDorg.wordpress.alpha
Commit6448c18
App Center BuildWPiOS - One-Offs #10044
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@geriux
Copy link
Member Author

geriux commented May 23, 2024

Tests fail because of the content added into the editor. Those should pass once we remove the hard-coded call to onVoiceToContent.

@geriux geriux added this to the 25.1 milestone May 23, 2024
@geriux geriux requested a review from twstokes May 23, 2024 11:19
@geriux geriux marked this pull request as ready for review May 23, 2024 11:19
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @geriux! 🚀

@kean
Copy link
Contributor

kean commented May 28, 2024

Hey, @geriux. I've been testing, and it's been working great so far, but I found a couple of missing features:

  • It correctly converts # Title to <h1>Title</h1> but doesn't place it in the dedicated space for the post title
  • If the original text contains only the title, it doesn't seem to produce any output

@geriux
Copy link
Member Author

geriux commented May 30, 2024

Hey, @geriux. I've been testing, and it's been working great so far, but I found a couple of missing features:

  • It correctly converts # Title to <h1>Title</h1> but doesn't place it in the dedicated space for the post title
  • If the original text contains only the title, it doesn't seem to produce any output

Thank you for the feedback @kean! I'll take a look!

@twstokes
Copy link
Contributor

  • It correctly converts # Title to <h1>Title</h1> but doesn't place it in the dedicated space for the post title

➕ I should've called that out, but assumed it was expected in the test. I saw it on both Android and iOS. Thanks @kean.

@geriux geriux force-pushed the gutenberg/voice-to-content branch from d42c779 to 6448c18 Compare May 31, 2024 10:26
@geriux geriux merged commit 9ef6def into trunk May 31, 2024
24 checks passed
@geriux geriux deleted the gutenberg/voice-to-content branch May 31, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants