[Mobile] - Adds new bridge functionality for content #61796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty that adds support to parse markdown content into blocks
geriux
added
[Status] In Progress
2 tasks
|
Size Change: 0 B Total Size: 1.74 MB ℹ️ View Unchanged
|
This was referenced May 20, 2024
geriux
commented
May 23, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in ff53958. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9206158007
|
dcalhoun
reviewed
May 24, 2024
twstokes
approved these changes
May 28, 2024
There was a problem hiding this comment.
LGTM @geriux! I'm approving, but we should consider David's feedback here. 🚀
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
* Mobile - Add onVoiceToContent bridge function * Mobile - Provider - Add listener for the onVoiceToContent functionality that adds support to parse markdown content into blocks * Adds integration test for onVoiceToContent * Rename onVoiceToContent to onContentUpdate * On Content Update, use the same functionality as in the Post Title component * Remove setting the title along side with the content * Update changelog Co-authored-by: geriux <geriux@git.wordpress.org> Co-authored-by: dcalhoun <dpcalhoun@git.wordpress.org> Co-authored-by: twstokes <twstokes@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* Mobile - Add onVoiceToContent bridge function * Mobile - Provider - Add listener for the onVoiceToContent functionality that adds support to parse markdown content into blocks * Adds integration test for onVoiceToContent * Rename onVoiceToContent to onContentUpdate * On Content Update, use the same functionality as in the Post Title component * Remove setting the title along side with the content * Update changelog Co-authored-by: geriux <geriux@git.wordpress.org> Co-authored-by: dcalhoun <dpcalhoun@git.wordpress.org> Co-authored-by: twstokes <twstokes@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This PR adds new functionality to the bridge to send content that will be inserted as blocks into the editor.
Why?
To allow other ways to create content from the host apps.
How?
Adds
onVoiceToContentin the Gutenberg bridge which expects markdown/plain text.The editor will then parse that content using
pasteHandlerwhich will handle it and convert it into blocks.Testing Instructions
Integration tests have been added to cover this new functionality.
There are also builds available that call
onVoiceToContentwhen the editor is opened to insert some hard-coded content.Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A