Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jetpack App Store keywords to include WordPress #23239

Merged
merged 3 commits into from
May 21, 2024

Conversation

staskus
Copy link
Contributor

@staskus staskus commented May 21, 2024

Context: p1715982219773889-slack-C072SR2B86Q

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 21, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23239-a590119
Version24.9
Bundle IDorg.wordpress.alpha
Commita590119
App Center BuildWPiOS - One-Offs #9960
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 21, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23239-a590119
Version24.9
Bundle IDcom.jetpack.alpha
Commita590119
App Center Buildjetpack-installable-builds #9010
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @staskus!

@guarani guarani added this to the 25.0 milestone May 21, 2024
@guarani
Copy link
Contributor

guarani commented May 21, 2024

Should we add this to the beta instead?

@kean
Copy link
Contributor

kean commented May 21, 2024

They don't? Great catch!

@guarani guarani force-pushed the task/add-wordpress-keyword-app-store branch from 968e176 to 04d9666 Compare May 21, 2024 19:31
@guarani guarani changed the base branch from trunk to release/24.9 May 21, 2024 19:32
@guarani guarani force-pushed the task/add-wordpress-keyword-app-store branch from 04d9666 to a590119 Compare May 21, 2024 19:33
@guarani guarani modified the milestones: 25.0, 24.9 ❄️ May 21, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.9 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@guarani
Copy link
Contributor

guarani commented May 21, 2024

I added wordpress to the other locales. I assume the localization process will still be triggered for 25.0, but translators will see that wordpress is already included in each locale and do nothing.

If we only modify the default locale, I think this change won't reach non-English locale users, which would be a missed opportunity IMO.

Again, if we target trunk instead of the release branch, we would miss the opportunity to change these keywords sonner since 25.0 will be released publicly in three more weeks.

Notes:

  • I used WordPress or wordpress depending on each locale. Some used capitals while others didn't.
  • I removed spaces from keyword lists since they're not needed
  • The order of the keywords doesn't matter

@guarani
Copy link
Contributor

guarani commented May 21, 2024

Looping in @salimbraksa as release wrangler: we've updated the Jetpack app's keywords to include WordPress since, surprisingly, it wasn't there. Having it lets us reach more people searching for WordPress, which should lead to more downloads.

I'm not sure if/how this change will affect the release process, but I can't see any issues yet. Feel free to reach out in p1715982219773889-slack-C072SR2B86Q if you have questions 🙇

@guarani guarani requested a review from kean May 21, 2024 19:46
@guarani
Copy link
Contributor

guarani commented May 21, 2024

👋 @kean, could you give this a review please? Asking so we can land this today since we're in the 2nd week of the beta.

@guarani guarani merged commit b6013e3 into release/24.9 May 21, 2024
25 of 26 checks passed
@guarani guarani deleted the task/add-wordpress-keyword-app-store branch May 21, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants