Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in PostSearchViewModel #23247

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix crash in PostSearchViewModel #23247

merged 1 commit into from
May 23, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented May 22, 2024

Fixes https://a8c.sentry.io/issues/1871799689/events/caa357e5119945fbbd9967901d2d899d/

To test:

  • Test that posts still show up in search results

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 25.0 milestone May 22, 2024
@kean kean requested a review from momo-ozawa May 22, 2024 18:38
@@ -81,7 +81,9 @@ final class PostSearchService {
offset += posts.count
hasMore = !posts.isEmpty

let newPosts = posts.filter { !postIDs.contains($0.objectID) }
let newPosts = posts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing defensive code was not enough to protected from the scenario when there are duplicated within a single response (posts). This is what I assume is causing the crash.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23247-be5aa1b
Version24.9
Bundle IDorg.wordpress.alpha
Commitbe5aa1b
App Center BuildWPiOS - One-Offs #9974
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23247-be5aa1b
Version24.9
Bundle IDcom.jetpack.alpha
Commitbe5aa1b
App Center Buildjetpack-installable-builds #9024
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean merged commit 892c8ee into trunk May 23, 2024
25 of 27 checks passed
@kean kean deleted the fix/crash-in-post-search branch May 23, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants