Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in PostSearchViewModel #23247

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix crash in PostSearchViewModel #23247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion WordPress/Classes/ViewRelated/Post/Search/PostSearchService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ final class PostSearchService {
offset += posts.count
hasMore = !posts.isEmpty

let newPosts = posts.filter { !postIDs.contains($0.objectID) }
let newPosts = posts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing defensive code was not enough to protected from the scenario when there are duplicated within a single response (posts). This is what I assume is causing the crash.

.deduplicated(by: \.objectID)
.filter { !postIDs.contains($0.objectID) }
postIDs.formUnion(newPosts.map(\.objectID))
self.delegate?.service(self, didAppendPosts: newPosts)
case .failure(let error):
Expand Down