Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Swift 1.2 #3560

Merged
merged 1 commit into from
Apr 22, 2015
Merged

Upgrading to Swift 1.2 #3560

merged 1 commit into from
Apr 22, 2015

Conversation

sendhil
Copy link
Contributor

@sendhil sendhil commented Apr 21, 2015

Merging work from #3554 and #3551. Thanks @nheagy and @alexcurylo for the hard work!

cc @astralbodies @jleandroperez

@jleandroperez jleandroperez added this to the 5.2 milestone Apr 22, 2015
@jleandroperez
Copy link
Contributor

I've added issue #3562 to review NSString <-> String interactions, and simplify when possible. I think some of those castings can be even removed, but let's tackle that in a different PR.

Looking great on my side! :shipit:

@aerych
Copy link
Member

aerych commented Apr 22, 2015

Took this for a spin and it looks good to me. There is one breaking test, NSStringHelpersTest testEllipsizing, but I don't see how it is related to this changes here.
I agree with @jleandroperez on reviewing NSStrings <-> Strings, but, yeah, that can be in a different scope. :)
:shipit:

@alexcurylo
Copy link
Contributor

That test broke for me in the Simulator too because CFStringTokenizerAdvanceToNextToken apparently suddenly started returning 0 when passed @"わたしはいぬがすきです". That seemed strange, so to test this against some other OS's and see if it was a real regression, I downloaded the 8.2 Simulator with 6.3.1 -- and that error went away! It also didn't show up running this branch through greenhouseci.com.

sendhil added a commit that referenced this pull request Apr 22, 2015
@sendhil sendhil merged commit 9abfd4f into develop Apr 22, 2015
@sendhil sendhil deleted the issue/upgrade-swift-to-12 branch April 22, 2015 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants