Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable media-text in all builds #1439

Merged
merged 6 commits into from Oct 14, 2019

Conversation

@koke
Copy link
Member

koke commented Oct 11, 2019

This enables the media&text block on production builds 馃帀

Gutenberg PR: WordPress/gutenberg#17903

To test:

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
@koke koke added the Blocks label Oct 11, 2019
@koke koke added this to the 1.15 milestone Oct 11, 2019
@koke koke requested a review from pinarol Oct 11, 2019
koke added 2 commits Oct 11, 2019
@koke koke requested a review from mkevins Oct 11, 2019
@koke koke marked this pull request as ready for review Oct 11, 2019
Copy link
Contributor

pinarol left a comment

Works good for WordPress-iOS 馃憤

@mkevins

This comment has been minimized.

Copy link
Contributor

mkevins commented Oct 14, 2019

Hi @koke 馃憢

As discussed, just pinging a reminder to update the bundles to include the fix from this one: WordPress/gutenberg#17899. 馃憤

koke added 3 commits Oct 14, 2019
@koke koke merged commit 57c630f into develop Oct 14, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@koke koke deleted the enable-media-text branch Oct 14, 2019
@phillipcornwell

This comment has been minimized.

Copy link

phillipcornwell commented Nov 3, 2019

Testing Environment:
iPhone 7 Plus
iOS 13.1.3

Results:
When I selected the image from my WordPress.com media library the app loaded a different image that was the most recently image added to the site's media library. Here is a short video on that:

https://cld.wthms.co/VQmRIn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.