Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable media-text in all builds #1439

Merged
merged 6 commits into from
Oct 14, 2019
Merged

Enable media-text in all builds #1439

merged 6 commits into from
Oct 14, 2019
+21 −20

Conversation

koke
Copy link
Member

@koke koke commented Oct 11, 2019 •
edited
Loading

This enables the media&text block on production builds 🎉

Gutenberg PR: WordPress/gutenberg#17903

To test:

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@koke koke added the Blocks label Oct 11, 2019
@koke koke added this to the 1.15 milestone Oct 11, 2019
@koke koke requested a review from pinarol October 11, 2019 10:02
@koke koke mentioned this pull request Oct 11, 2019
Merged
@koke koke requested a review from mkevins October 11, 2019 10:21
@koke koke marked this pull request as ready for review October 11, 2019 10:58
pinarol
pinarol approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good for WordPress-iOS 👍

@mkevins
Copy link
Contributor

mkevins commented Oct 14, 2019

Hi @koke 👋

As discussed, just pinging a reminder to update the bundles to include the fix from this one: WordPress/gutenberg#17899. 👍

@koke koke merged commit 57c630f into develop Oct 14, 2019
@koke koke deleted the enable-media-text branch October 14, 2019 11:19
@phillipcornwell
Copy link

Testing Environment:
iPhone 7 Plus
iOS 13.1.3

Results:
When I selected the image from my WordPress.com media library the app loaded a different image that was the most recently image added to the site's media library. Here is a short video on that:

https://cld.wthms.co/VQmRIn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

@mkevins mkevins Awaiting requested review from mkevins

Assignees
No one assigned
Labels
Blocks
Projects
None yet
Milestone
1.15
Development

Successfully merging this pull request may close these issues.
4 participants
@koke @mkevins @phillipcornwell @pinarol