Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update React Native to version 0.62.2 #2439

Closed
wants to merge 10 commits into from
Closed

Update React Native to version 0.62.2 #2439

wants to merge 10 commits into from

Conversation

SergioEstevao
Copy link
Contributor

Update React Native to 0.62.0

Gutenberg PR: WordPress/gutenberg#19950
WordPressAndroid: wordpress-mobile/WordPress-Android#11217
WordPressiOS: wordpress-mobile/WordPress-iOS#13752
react-native-video PR: wordpress-mobile/react-native-video#5
react-native-svg PR: wordpress-mobile/react-native-svg#10

To test: Gutenberg Editor should work as expected.
Try to run manual tests from the list.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added the [Type] Enhancement Improves a current area of the editor label Jun 29, 2020
@SergioEstevao SergioEstevao added this to the 1.32 milestone Jun 29, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 29, 2020 •
edited

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SergioEstevao SergioEstevao mentioned this pull request Jun 29, 2020
Closed
2 tasks
@mchowning
Copy link
Contributor

mchowning commented Jul 7, 2020 •
edited

Bumping this PR to 1.34 (the furthest milestone we currently have) since we're getting ready to cut the 1.32 branches. Feel free to update the milestone as appropriate.

@mchowning mchowning modified the milestones: 1.32, 1.34 Jul 7, 2020
@marecar3 marecar3 mentioned this pull request Jul 13, 2020
Closed
6 tasks
@SergioEstevao
Copy link
Contributor Author

The current version of this PR is building and running the demo app correctly, but the E2E tests locally and on CI are failing.

The reason for this is that until now the react-native tools for iOS were build the app in the following folder gutenberg/packages/react-native-editor/ios/build/gutenberg/Build/Products/Release-iphonesimulator/GutenbergDemo.app

And for the running the E2E tests we have hardcode this path on the following scripts:

  • gutenberg/packages/react-native-editor/package.json on the following steps:
  • test:e2e:bundle:ios
  • clean:build-artifacts
  • gutenberg/package/react-native-editor/__device-tests__/helpers/utils,js on the defaultIOSAppPath
  • .circleci/config.yml
  • gutenberg/.github/workflows/rnmobile-ios-runner.yml
  • package.json for the following steps:
  • test:e2e:bundle:ios
  • clean:build-artifacts

The react-native tools in 0.62.2 now build the app to the default folders that are configured inside Xcode at a global level.
They are now building somewhere inside the Xcode folders.

To solve this there are two possible solutions:

  • change the scripts above to use the new folder by grabbing the folder with this command xcodebuild -workspace gutenberg.xcworkspace -scheme gutenberg -configuration Release -sdk iphonesimulator -showBuildSettings | grep TARGET_BUILD_DIR | cut -d '=' -f2
  • Change the build step of the scripts to force the creation of the build artifacts on the old folder.

@ceyhun
Copy link
Contributor

ceyhun commented Aug 3, 2020

We're getting ready to cut the 1.34 release branch, so I'm bumping this to the 1.35 milestone.

@ceyhun ceyhun modified the milestones: 1.34, 1.35 Aug 3, 2020
@cameronvoell
Copy link
Contributor

We're getting ready to cut the 1.34 release branch, so I'm bumping this to the 1.35 milestone.

Bumping to 1.36

@cameronvoell cameronvoell modified the milestones: 1.35, 1.36 Aug 17, 2020
@cameronvoell
Copy link
Contributor

Bumping to 1.37

@cameronvoell cameronvoell modified the milestones: 1.36, 1.37 Aug 31, 2020
@jd-alexander
Copy link
Contributor

Bumping this milestone to 1.38

@jd-alexander jd-alexander modified the milestones: 1.37, 1.38 Sep 4, 2020
@hypest hypest removed this from the 1.38 milestone Sep 18, 2020
@ceyhun
Copy link
Contributor

ceyhun commented Nov 17, 2020

Closing in favor of #2580

@ceyhun ceyhun closed this Nov 17, 2020
@ceyhun ceyhun deleted the try/update_RN_0.62.2 branch November 17, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom Awaiting requested review from etoledom

@marecar3 marecar3 Awaiting requested review from marecar3

Assignees
No one assigned
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SergioEstevao @mchowning @ceyhun @cameronvoell @jd-alexander @hypest