Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade RN to 0.62.2 #1823

Closed
wants to merge 130 commits into from
Closed

Upgrade RN to 0.62.2 #1823

wants to merge 130 commits into from

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Jan 27, 2020

Update React Native to 0.62.0

Gutenberg PR: WordPress/gutenberg#19950
WordPressAndroid: wordpress-mobile/WordPress-Android#11217
WordPressiOS: wordpress-mobile/WordPress-iOS#13752
react-native-video PR: wordpress-mobile/react-native-video#5
react-native-svg PR: wordpress-mobile/react-native-svg#10

To test: Gutenberg Editor should work as expected.
Try to run manual tests from the list.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Update React to 16.12.0
@marecar3 marecar3 added the [Type] Enhancement Improves a current area of the editor label Jan 27, 2020
@marecar3 marecar3 mentioned this pull request Jan 27, 2020
2 tasks
@marecar3 marecar3 changed the title Upgrade RN to 0.62.0-rc.1 Upgrade RN to 0.62 Jan 27, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 22, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SergioEstevao SergioEstevao modified the milestones: 1.29, 1.30 May 25, 2020
@lukewalczak
Copy link
Contributor

Hello @marecar3, we cannot remove the whole react-native patch (part related to shadow view can be deleted since these changes are already merged into react-native), along with patch-package lib and script, because recently I had to add new patch for disabling buttons in action sheet. The same patch is applied in iOS app.

I can create a commit with patching to 0.62 if you would like to ✌️

@SergioEstevao
Copy link
Contributor

SergioEstevao commented May 26, 2020 via email

@lukewalczak
Copy link
Contributor

This new patch comes from what version of React Native?

0.61.5 - the current version on gb-mobile

@marecar3
Copy link
Contributor Author

Hello @marecar3, we cannot remove the whole react-native patch (part related to shadow view can be deleted since these changes are already merged into react-native), along with patch-package lib and script, because recently I had to add new patch for disabling buttons in action sheet. The same patch is applied in iOS app.

I can create a commit with patching to 0.62 if you would like to ✌️

Hey @lukewalczak, thanks for the ping.
Yes, please if you can, revert back patch with changes that we need for RN 0.62.2

@lukewalczak
Copy link
Contributor

Between the versions 0.61.5 and 0.62.2 they've changed the structure a bit, so I have to apply the new patch. Will handle it!

@marecar3
Copy link
Contributor Author

Between the versions 0.61.5 and 0.62.2 they've changed the structure a bit, so I have to apply the new patch. Will handle it!

Thanks a lot for helping with that one!

@mchowning
Copy link
Contributor

We're preparing to cut the 1.30 release branches, so I'm going to bump this to 1.31. If this needs to make it in the 1.30 release though, just let me know. 🙂

@SergioEstevao
Copy link
Contributor

Closing this PR in favor of: #2439 that is based on the monorepo work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants