-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade RN to 0.62.2 #1823
Upgrade RN to 0.62.2 #1823
Conversation
Update React to 16.12.0
# Conflicts: # gutenberg
# Conflicts: # ios/Podfile.lock
# Conflicts: # ios/Podfile.lock
# Conflicts: # gutenberg # ios/Podfile.lock # package.json # yarn.lock
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
# Conflicts: # react-native-aztec/android/build.gradle
# Conflicts: # patches/react-native+0.61.5.patch
Hello @marecar3, we cannot remove the whole react-native patch (part related to shadow view can be deleted since these changes are already merged into react-native), along with I can create a commit with patching to 0.62 if you would like to ✌️ |
This new patch comes from what version of React Native?
…On Tue, 26 May 2020 at 11:14, Luke Walczak ***@***.***> wrote:
Hello @marecar3 <https://github.com/marecar3>, we cannot remove the whole
react-native patch (*part related to shadow view can be deleted since
these changes are already merged into react-native*), along with
patch-package lib and script, because recently I had to add new patch
<https://github.com/wordpress-mobile/gutenberg-mobile/pull/2220/files#diff-6c5ad6f771a45ea3b93efab244996f4eR1>
for disabling buttons in action sheet. The same patch
<wordpress-mobile/WordPress-iOS#14062> is applied
in iOS app.
I can create a commit with patching to 0.62 if you would like to ✌️
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1823 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE7CUID7FUPFGUWWMFEZ23RTOJBRANCNFSM4KMFH36A>
.
|
0.61.5 - the current version on gb-mobile |
Hey @lukewalczak, thanks for the ping. |
Between the versions 0.61.5 and 0.62.2 they've changed the structure a bit, so I have to apply the new patch. Will handle it! |
Thanks a lot for helping with that one! |
We're preparing to cut the 1.30 release branches, so I'm going to bump this to 1.31. If this needs to make it in the 1.30 release though, just let me know. 🙂 |
Closing this PR in favor of: #2439 that is based on the monorepo work. |
Update React Native to 0.62.0
Gutenberg PR: WordPress/gutenberg#19950
WordPressAndroid: wordpress-mobile/WordPress-Android#11217
WordPressiOS: wordpress-mobile/WordPress-iOS#13752
react-native-video PR: wordpress-mobile/react-native-video#5
react-native-svg PR: wordpress-mobile/react-native-svg#10
To test: Gutenberg Editor should work as expected.
Try to run manual tests from the list.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.