Update gutenberg hash for changing block mover wording #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guarani
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
Tested using da3dcd4:
(I can review the Gutenberg PR but can't seem to find it, could you please add a link?)
- Insert paragraph block and type text.
- Insert heading block.
- Long press up block mover.
- Confirm that title on popped up action sheet says 'Change block position'.
Looks good to me! 💯
illusaen
force-pushed
the
change_block_mover_wording
branch
from
da3dcd4
to
2f2c925
Compare
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
added 2 commits
February 9, 2021 13:06
…ck position' to 'Change block position'.
…ck position' to 'Change block position'. gutenberg hash change for changing block mover wording from 'Move block position' to 'Change block position'.
illusaen
force-pushed
the
change_block_mover_wording
branch
from
2f2c925
to
aab4a93
Compare
|
For reference while testing, the related gutenberg PR is: WordPress/gutenberg#28454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates block mover title wording from 'Move block position' to 'Change block position'.
See #3044 for screenshots.
To test:
PR submission checklist: