Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle floating keyboard case (iOS only) #3687

Merged
merged 3 commits into from
Jul 1, 2021
Merged

Handle floating keyboard case (iOS only) #3687

merged 3 commits into from
Jul 1, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jun 30, 2021 •
edited
Loading

gutenberg PR: WordPress/gutenberg#33089

To test:
Use the testing instructions from the gutenberg PR: WordPress/gutenberg#33089.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the [Type] Bug Something isn't working label Jun 30, 2021
@fluiddot fluiddot added this to the 1.57.0 (17.8) milestone Jun 30, 2021
@fluiddot fluiddot requested a review from geriux June 30, 2021 15:54
@fluiddot fluiddot self-assigned this Jun 30, 2021
@fluiddot fluiddot mentioned this pull request Jun 30, 2021
Merged
7 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 30, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

geriux
geriux approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#33089 (comment) nice work!

@fluiddot fluiddot merged commit b5c31ba into develop Jul 1, 2021
@fluiddot fluiddot deleted the fix/ios-floating-keyboard branch July 1, 2021 09:53
@ceyhun ceyhun mentioned this pull request Jul 9, 2021
Merged
5 tasks
@fluiddot fluiddot changed the title Handle floating keyboard case Handle floating keyboard case (iOS only) Jul 12, 2021
@fluiddot
Copy link
Contributor Author

I've updated the title and added the iOS tag because this fix only applies to iOS (sorry for not detailing this before 🙏 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees

@fluiddot fluiddot

Labels
[OS] iOS [Type] Bug Something isn't working
Projects
None yet
Milestone
1.57.0 (17.8)
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @geriux