Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embed block] Enable WordPress embed preview #3853

Merged
merged 8 commits into from Sep 3, 2021
Merged

[Embed block] Enable WordPress embed preview #3853

merged 8 commits into from Sep 3, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Aug 19, 2021 •
edited

gutenberg PR: WordPress/gutenberg#34004

Fixes #3744

To test:
Follow testing instructions from gutenberg PR: WordPress/gutenberg#34004

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot self-assigned this Aug 19, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 20, 2021 •
edited

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot marked this pull request as ready for review August 20, 2021 16:05
@fluiddot fluiddot requested a review from ceyhun August 20, 2021 16:05
@fluiddot fluiddot mentioned this pull request Aug 20, 2021
Merged
7 tasks
@fluiddot fluiddot mentioned this pull request Sep 1, 2021
Closed
ceyhun
ceyhun approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#34004, we might need to update the release notes 💯

@fluiddot
Copy link
Contributor Author

fluiddot commented Sep 3, 2021

Approved via WordPress/gutenberg#34004, we might need to update the release notes 💯

Right, I'll update the release notes too 👍 .

@fluiddot fluiddot changed the title [Embed block] Implement WP embed preview component [Embed block] Enable WordPress embed preview Sep 3, 2021
@fluiddot fluiddot added this to the 1.62.0 (18.3) milestone Sep 3, 2021
@fluiddot
Copy link
Contributor Author

fluiddot commented Sep 3, 2021

Approved via WordPress/gutenberg#34004, we might need to update the release notes 💯

Right, I'll update the release notes too 👍 .

I've updated the release notes in this commit.

@fluiddot fluiddot merged commit cc82854 into develop Sep 3, 2021
@fluiddot fluiddot deleted the embed-block-wp-embed branch September 3, 2021 16:30
@enejb enejb mentioned this pull request Sep 17, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceyhun ceyhun ceyhun approved these changes

Assignees

@fluiddot fluiddot

Labels
Embed block [Type] Task
Projects
None yet
Milestone
1.62.0 (18.3)
Development

Successfully merging this pull request may close these issues.

[Embed block] Implement WP embed preview component
2 participants
@fluiddot @ceyhun