Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embed block] Add the top 5 specific embed blocks to the Block inserter list #3995

Merged
merged 12 commits into from
Sep 30, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Sep 20, 2021

gutenberg PR: WordPress/gutenberg#34967

To test:
Follow testing instructions from gutenberg PR: WordPress/gutenberg#34967.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 21, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fluiddot
Copy link
Contributor Author

Heads up that I'm going to make a little change in the Gutenberg PR to disable the colored icon versions as has been discussed internally (p1632907802004300-slack-C01MTUVN9T3).

cc @jd-alexander

@fluiddot fluiddot added this to the 1.63.0 (18.4) milestone Sep 30, 2021
@fluiddot fluiddot merged commit 139c76c into develop Sep 30, 2021
@fluiddot fluiddot deleted the embed-block-add-top-providers-inserter branch September 30, 2021 11:51
@guarani guarani mentioned this pull request Oct 1, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Embed block] Add the top 5 specific embed blocks to the Block inserter list
2 participants