Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embed block] Fix URL not editable after dismissing the edit URL bottom sheet with empty value #4094

Merged
merged 4 commits into from Oct 13, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Oct 8, 2021

Gutenberg PR: WordPress/gutenberg#35460

Fixes #4093

To test:
Follow testing instructions from Gutenberg PR WordPress/gutenberg#35460.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 8, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot added this to the 1.64.0 (18.5) milestone Oct 8, 2021
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geriux
Copy link
Member

geriux commented Oct 13, 2021

Hey @fluiddot 👋. We will cut the 1.64.0 release on 10/14. I plan to circle back and bump this PR to the next milestone then, but please let me know if you'd rather us work to include this PR in 1.64.0. Thanks!

@fluiddot
Copy link
Contributor Author

Hey @fluiddot 👋. We will cut the 1.64.0 release on 10/14. I plan to circle back and bump this PR to the next milestone then, but please let me know if you'd rather us work to include this PR in 1.64.0. Thanks!

Thanks for the ping 🙇 , I'm going to merge the PR today as it's already approved, so if possible I'd like to include it in 1.64.0.

@fluiddot fluiddot merged commit 5c8bb98 into develop Oct 13, 2021
@fluiddot fluiddot deleted the fix/embed-block-set-empty-url branch October 13, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Embed block [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Embed block] Can't set URL after dismissing the edit URL bottom sheet with empty value
3 participants