Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section styles: improve (or remove) preview #63035

Closed
annezazu opened this issue Jul 1, 2024 · 9 comments · Fixed by #63114
Closed

Section styles: improve (or remove) preview #63035

annezazu opened this issue Jul 1, 2024 · 9 comments · Fixed by #63114
Assignees
Labels
[Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Jul 1, 2024

Currently, the previews for block style variations don't offer much value when applied to styling sections of blocks with the new feature in 6.6. If anything, the preview looks broken and doesn't match all of the changes one can expect to see:

Screenshot 2024-07-01 at 11 34 44 AM

Here's a video:

Section.Styles.previews.mov

As a result, I think we should either remove these previews for Groups & Columns for now or consider a way to improve the preview offered cc @aaronrobertshaw

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks labels Jul 1, 2024
@bgardner
Copy link

bgardner commented Jul 1, 2024

+1 for improving (or removing) previews for section styles.

@aaronrobertshaw
Copy link
Contributor

Just flagging that there were a couple of earlier explorations into updating the UI for Block Styles:

While these were focused on the control itself, e.g. dropdown vs small cards etc., it did come up that the preview isn't really required as it was so easy to see it in action or switch back to the default.

I can put together a quick PR to remove the preview and see what people think.

@bgardner
Copy link

bgardner commented Jul 2, 2024

I can put together a quick PR to remove the preview and see what people think.

TBH, I think this is better (and likely easier to ship with RC2?) to remove than to style a preview.

@aaronrobertshaw
Copy link
Contributor

and likely easier to ship with RC2?

I think this might be seen more as an enhancement rather than a bug fix, so I don't think it will make it into any of the 6.6 RCs.

@bgardner
Copy link

bgardner commented Jul 2, 2024

Heh, I could make the argument that it is a bug, but that would only be wishful thinking.

In short, I understand and agree with what you said.

@aaronrobertshaw
Copy link
Contributor

A draft PR is up for removing the block style previews from the inspector panel only: #63039.

I am having some problems with my local native env at the moment so I've left the PR in a draft state until I can sort that out and see whether it still makes sense to remove the previews there too.

@aaronrobertshaw
Copy link
Contributor

The block styles still use an inline preview for the native UI. Given the next iteration of section styles/block style variations will likely involve a major update to this panel, I wonder if it makes sense to hold off on updating the native UI.

I've suggested over on #63039 that this could be a separate follow-up but happy to hear other's thoughts on this one.

@annezazu
Copy link
Contributor Author

annezazu commented Jul 2, 2024

Thanks for the quick work here.

@aaronrobertshaw
Copy link
Contributor

The removal of previews appears to be overkill. An alternate approach, simply improving the Group block's example, is available in #63114.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
3 participants