Project management: Add prepublish packages command for npm releases #19214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
the
[Type] Project Management
gziolo
commented
Dec 18, 2019
| await runPushGitChangesStep( releaseBranch, abortMessage ); | ||
|
|
||
| abortMessage = 'Aborting! The release is finished though.'; | ||
| await runCleanLocalCloneStep( abortMessage ); |
There was a problem hiding this comment.
This references svn folder which doesn’t exist in this context causing errors.
youknowriad
reviewed
Dec 19, 2019
youknowriad
approved these changes
Dec 19, 2019
Co-Authored-By: Riad Benguella <benguella@gmail.com>
gziolo
commented
Dec 19, 2019
| svnWorkingDirectoryPath, | ||
| ].map( async ( directoryPath ) => { | ||
| if ( fs.existsSync( directoryPath ) ) { | ||
| await rimraf( directoryPath, ( err ) => { |
There was a problem hiding this comment.
They do the same trick in rimraf in their bin implementation:
https://github.com/isaacs/rimraf/blob/d82bc81f251ba2cc86dc26361a820631091b3e9e/bin.js#L44-L48
There was a problem hiding this comment.
It fixes the following error I observed locally:
The following error happened during the "Cleaning the temporary folder" step:
AssertionError [ERR_ASSERTION]: rimraf: callback function required
at rimraf (/Users/gziolo/PhpstormProjects/gutenberg/node_modules/rimraf/rimraf.js:52:10)
|
It was tested already on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new command which handles prepublish to npm steps for a stable version of WordPress packages.
At the moment it only covers those steps which handle git management before Lerna takes over publishing to npm.
Check more details about the manual process in https://github.com/WordPress/gutenberg/blob/master/docs/contributors/release.md#synchronizing-wordpress-trunk.
How has this been tested?
./bin/commander.js prepublish-packages-stableChecklist: