-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrections to Brazil #187
Comments
hello and thank you for this report.... Are all these days observed holidays? that is to say "non-working days"? |
All of these mentioned are "non-working days". When mentioning this, I was just starting to look for functions for school holidays or academic holidays as well, as I use this for bus routes, and some bus routes have foot notes like (S, Only on School days), but I guess that will have to include a whole new variable in addition to the existing. For the RJ I have observed deviations from the list I have posted, but this list is as far as I know all the official days, or derived from official sources. |
Ok, so I guess that we're going to need a |
With a little investigation I can give you the rest of the 78 municipalities of |
|
next question is: are all these holidays fixed holidays, or may they vary? |
All of those I have stated with a fixed date are fixed, what I have placed as Carnaval is 47 days before easter, I noticed it was already included in RJ state have a |
According to this link, |
I'm currently working on these Brazil calendars, as you can see, and I've got an issue with "Rio de Janeiro".
Also, it looks like the "Dia do Comércio" is a holiday for shops and civil-construction workers.
|
oh, about the "Zumbi dos Palmares", it looks like it's the same as "Dia da Consciência Negra"... rephrasing my question for this one: *Which label shall I use?" |
My source might be incomplete, so you can include the missing days from wikipedia
Zumbi and Conceição Negra is the same, though I think Rio use the term Zumbi. I am not 100% certain what term is used where
Dia do Comércio was mentioned in my source, though I think it might not be observed equally by private sector and government
…Sent from my iPhone
On 24 May 2017, at 11:19, Bruno Bord ***@***.***> wrote:
oh, about the "Zumbi dos Palmares", it looks like it's the same as "Dia da Consciência Negra"... rephrasing my question for this one: *Which label shall I use?"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
ah, it's the other way around: Wikipedia doesn't mention the RJ days you're providing in the issue. |
Would guess Wikipedia incomplete too
…Sent from my iPhone
On 24 May 2017, at 11:37, Bruno Bord ***@***.***> wrote:
My source might be incomplete, so you can include the missing days from wikipedia
ah, it's the other way around: Wikipedia doesn't mention the RJ days you're providing in the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
All right, i'll go on like this until "some carioca" complains about the wrong dates ;o) |
No problem, I might as well add more as I need, those suggested currently covers my needs and some
…Sent from my iPhone
On 24 May 2017, at 11:49, Bruno Bord ***@***.***> wrote:
All right, i'll go on like this until "some carioca" complains about the wrong dates ;o)
thx for the clarification.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Note: to implement this calendar, we had to add a ``good_friday_label``. As of now, the "Good Friday" label is a parameter that can be changed
Note: to implement this calendar, we had to add a ``ash_wednesday_label``. As of now, the "Ash Wednesday" label is a parameter that can be changed
De-duplicated: São Pedro, São João, São José, Dia do Servidor Público, Consciência Negra, Nossa Senhora da Conceição
Were added: Acre, Alagoas, Amapá, Amazonas, Bahia, Ceará, Distrito Federal, Espírito Santo State, Goiás, Maranhão, Mato Grosso, Mato Grosso do Sul, Pará, Paraíba, Pernambuco, Piauí, Rio de Janeiro, Rio Grande do Norte, Rio Grande do Sul, Rondônia, Roraima, Santa Catarina, São Paulo, Sergipe, Tocantins, City of Vitória, City of Vila Velha, City of Cariacica, City of Guarapari and City of Serra.
The version 1.2.0 is now published: you can install it via pip! Closing. Don't hesitate to open an issue or a PR to fix eventual bugs or suggest improvements |
I noticed that Easter is not returned in Brazil, looking at the source code
america.py
, I see it is placed in BrazilSaoPauloCity, the same with Carnaval.I am listing below all state holidays, and a few municipalities within Espírito Santo.
Acre (AC)
Alagoas (AL)
Amapá (AP)
Amazonas (AM)
Bahia (BA)
Ceará (CE)
Distrito Federal (DF)
Espírito Santo State (ES)
Goiás (GO)
Maranhão (MA)
Mato Grosso (MT)
Mato Grosso do Sul (MS)
Pará (PA)
Paraíba (PB)
Pernambuco (PE)
Piauí (PI)
Rio de Janeiro (RJ)
Rio Grande do Norte (RN)
Rio Grande do Sul (RS)
Rondônia (RO)
Roraima (RR)
Santa Catarina (SC)
São Paulo (SP)
Sergipe (SE)
Tocantins (TO)
City of Vitória / ES
List decorated by Municipal Law
City of Vila Velha / ES
City of Viana / ES
City of Cariacica / ES
City of Guarapari / ES
City of Serra / ES
The text was updated successfully, but these errors were encountered: