New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the "chinese new year shift" #202
Comments
brunobord
added a commit
that referenced
this issue
Jun 12, 2017
This module is a "merge" that handles Chinese New Year various computations, from the calculations of its eve, day, second day, and the eventual shift that can occur if it falls on Sunday.
brunobord
added a commit
that referenced
this issue
Jun 12, 2017
brunobord
added a commit
that referenced
this issue
Jun 23, 2017
- Major refactor in the USA module. Each State is now an independant module, all of the Mixins were removed, all the possible corrections have been made, following the main Wikipedia page, and cross-checking with official sources when it was possible (#171). - Added District of Columbia in the USA module (#217). - Run tests with Python3.6 in CI (#210) - Small refactors / cleanups in the following calendars: Hungary, Iceland, Ireland, Latvia, Netherlands, Spain, Japan, Taiwan, Australia, Canada, USA (#209). - Various refactors for the Asia module, essentially centered around a more convenient Chinese New Year computation toolset (#202). - Refactoring the USA tests: using inheritance to test federal and state-based holidays using only one "Don't Repeat Yourself" codebase (#213).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This Sunday shift is occurring in both Singapore and Malaysia calendars (and possibly others).
That might be possible to modularize this mechanism for it to be reused and avoid to have to change in several places if there's a fix to apply.
The text was updated successfully, but these errors were encountered: