Minor cleanups #209
Merged
Minor cleanups #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobord
force-pushed
the
small-refactors-variable-days
branch
2 times, most recently
from
e461522
to
9bd824f
Compare
* Hungary: a more clever take on the Good Friday rule * Iceland: using ``extend`` instead of ``+=`` * Ireland: a more clever take on Whit Monday rule * Latvia: using ``extend`` for lists, instead of ``+=`` * Netherlands: using ``.append`` for just *one* day to add * Spain: remove the ugly ``u''`` * Japan: readability changes * Taiwan: using ``extend`` for lists, instead of ``+=`` * Canada: using ``extend`` and ``append`` for lists * Australia: using ``extend`` instead of ``+=`` + minor code reflow * USA: using ``extend`` and ``append`` when needed, fixed a few docstrings, removed unnecessary 'super' calls
brunobord
force-pushed
the
small-refactors-variable-days
branch
from
9bd824f
to
f2fd603
Compare
brunobord
added a commit
that referenced
this pull request
Jun 23, 2017
- Major refactor in the USA module. Each State is now an independant module, all of the Mixins were removed, all the possible corrections have been made, following the main Wikipedia page, and cross-checking with official sources when it was possible (#171). - Added District of Columbia in the USA module (#217). - Run tests with Python3.6 in CI (#210) - Small refactors / cleanups in the following calendars: Hungary, Iceland, Ireland, Latvia, Netherlands, Spain, Japan, Taiwan, Australia, Canada, USA (#209). - Various refactors for the Asia module, essentially centered around a more convenient Chinese New Year computation toolset (#202). - Refactoring the USA tests: using inheritance to test federal and state-based holidays using only one "Don't Repeat Yourself" codebase (#213).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extendinstead of+=extendfor lists, instead of+=.appendfor just one day to addu''extendfor lists, instead of+=extendandappendfor listsextendinstead of+=+ minor code reflowextendandappendwhen needed, fixed a few docstrings, removed unnecessary 'super' calls