Update singapore.py #282
Closed
Update singapore.py #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added DEEPAVALI holidays for 2019 and 2020
brunobord
requested changes
Sep 14, 2018
There was a problem hiding this comment.
too bad, there's just a tiny fix to do in order to have the green tests with your code.
workalendar/asia/singapore.py:50:33: E261 at least two spaces before inline comment
Also, I'd recommend you to have a look at the contributing document. Your PR is cool, but it lacks a few items to make it in master:
- Add some tests for the years you've added.
- A Changelog item describing the change. For example: "Added DEEPAVALI holidays for 2019 and 2020 in Singapore calendar"
|
I'm going to take this PR over. don't worry, it'll be harmless :o) |
2 tasks
brunobord
added a commit
that referenced
this pull request
Dec 6, 2018
Only bugfixes: - Added DEEPAVALI days for 2019 and 2020, thx @pvalenti (#282). - Fixed Germany Reformation Day miscalculation. Some German states include Reformation Day since the "beginning" ; in 2017, all states included Reformation Day as a holiday (500th anniversary of the Reformation) ; starting of 2018, 4 states added Reformation Day (#295).
|
Fixed and released on v3.2.1 - happy upgrading! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added DEEPAVALI holidays for 2019 and 2020