Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Philippines Holidays #396

Closed
micodls opened this issue Aug 13, 2019 · 4 comments
Closed

Add support for Philippines Holidays #396

micodls opened this issue Aug 13, 2019 · 4 comments
Projects
Workalendar

Comments

@micodls
Copy link
Contributor

micodls commented Aug 13, 2019

Sources: https://www.timeanddate.com/holidays/philippines/
@Natim
Copy link
Contributor

Natim commented Aug 13, 2019 •
edited

Hello @micodls are you able to start a PR to contribute the calendar?

@micodls
Copy link
Contributor Author

micodls commented Aug 13, 2019

I can try do this over the week.

@brunobord
Copy link
Member

I'd be glad to review your pull-request when it's ready.
Do not hesitate to cross-check holidays with Wikipedia or any other official resources you can find about it.

@brunobord brunobord added this to To Do in Workalendar Aug 23, 2019
@brunobord brunobord moved this from To Do to Blocked / on Hold in Workalendar Nov 15, 2019
@micodls micodls mentioned this issue Aug 18, 2021
Merged
5 tasks
brunobord added a commit that referenced this issue Sep 16, 2021
@brunobord
v16.0.0
2f2d084 
**Warning**: Important changes in the runtime requirements. Please have a look at the README for more information.

**New calendar**

- New calendar: Added Philippines calendar by @micodls (#396)

**Internal changes**

- Remove `skyfield` dependency, added `[astronomy]` as extra dependency (#660).
- Replace `pyCalverter` with `convertdate` (#536).
- Remove unused `JalaliMixin`
- Replace `pkg_resources` with `importlib_metadata` to fetch the version number in `__init__.py` (#657)
- Added new badges (pypi, conda, license) and installation instructions (pip, conda) to readme file @sugatoray (#673).
- Added the "Workalendar maintainers" in the LICENSE file.
- Changed the maintainer email.
@brunobord brunobord mentioned this issue Sep 16, 2021
Merged
14 tasks
@brunobord
Copy link
Member

The latest release (16.0.0) includes your fresh-new Philippines calendar. Congrats!

Happy upgrading!

Workalendar automation moved this from Blocked / on Hold to Done/Closed/Published Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Workalendar
  
Done/Closed/Published
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brunobord @Natim @micodls