Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added philippines calendar #678

Merged
merged 3 commits into from Sep 10, 2021
Merged

Conversation

micodls
Copy link
Contributor

@micodls micodls commented Aug 18, 2021

refs #396

For information, read and make sure you're okay with the Contributing guidelines.

  • Tests with a significant number of years to be tested for your calendar.
  • Docstrings for the Calendar class and specific methods.
  • Use the workalendar.registry_tools.iso_register decorator to register your new calendar using ISO codes (optional).
  • Calendar country / label added to the README.md file.
  • Changelog amended with a mention like: "Added <country> by @pseudo (#)". Note Please do NOT change the version number here. It's the project maintainers' duty.

@ewjoachim
Copy link
Contributor

(ping @brunobord to run the CI ;) )

Changelog.md Outdated Show resolved Hide resolved
workalendar/core.py Outdated Show resolved Hide resolved
workalendar/core.py Outdated Show resolved Hide resolved
workalendar/tests/test_asia.py Show resolved Hide resolved
@brunobord brunobord merged commit 380fffb into workalendar:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants