Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BrazilBankCalendar ignore include_* flags #474

Closed
iurisilvio opened this issue Mar 20, 2020 · 1 comment · Fixed by #478
Closed

BrazilBankCalendar ignore include_* flags #474

iurisilvio opened this issue Mar 20, 2020 · 1 comment · Fixed by #478
Labels
small improvement Small steps, but nice to have

Comments

@iurisilvio
Copy link
Contributor

iurisilvio commented Mar 20, 2020 •
edited

https://github.com/peopledoc/workalendar/blob/master/workalendar/america/brazil.py#L605-L631

I want to extend BrazilBankCalendar to don't consider ash_wednesday, but I had to rewrite the get_variable_days for that.

Works for me, but could be better.
@iurisilvio iurisilvio mentioned this issue Mar 20, 2020
Merged
2 tasks
@brunobord brunobord added the small improvement Small steps, but nice to have label Mar 27, 2020
brunobord added a commit that referenced this issue Apr 3, 2020
@brunobord
v8.2.1
e757426 
Change:

- Added BrazilBankCalendar to support `include_` flags and make it possible to extend and change these flags to support custom bank calendars (#474).
@brunobord brunobord mentioned this issue Apr 3, 2020
Merged
14 tasks
@brunobord
Copy link
Member

Release pushed on PyPI. Happy upgrade! https://pypi.org/project/workalendar/8.2.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
small improvement Small steps, but nice to have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v8.2.1 workalendar/workalendar
2 participants
@brunobord @iurisilvio