Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BrazilBankCalendar to use include_* flags #475

Merged
merged 1 commit into from Apr 3, 2020
Merged

Refactor BrazilBankCalendar to use include_* flags #475

merged 1 commit into from Apr 3, 2020

Conversation

iurisilvio
Copy link
Contributor

@iurisilvio iurisilvio commented Mar 20, 2020

It is really useful to allow reuse of this class. Brazilian bank calendar is not always the same.

For my use case, I just want to remove ash wednesday, but for that I have to override get_variable_days().

  • Tests with a significant number of years to be tested for your calendar.
  • Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.

Related #474

@brunobord
Copy link
Member

Thank you very much for this very valuable change, it makes much more sense now.
To be honest, I think we could also remove the redefinition of Christmas Day. In every Christian calendar, Christmas Day is a holiday, so I wonder why it was added in the first place.

Do you think you could add this small patch to your PR, please? (otherwise I may give it a go later on)

It is really useful to allow reuse of this class.
@iurisilvio
Copy link
Contributor Author

Done! Removed Christmas Day.

@brunobord
Copy link
Member

a bit overwhelmed at the moment, but I'm going to merge this and make a bugfix release as soon as I can. thank you again a bunch for this patch, I love it!

@brunobord brunobord merged commit 5370b45 into workalendar:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants