Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve coverage where it's possible #546

Closed
15 tasks done
brunobord opened this issue Sep 4, 2020 · 0 comments
Closed
15 tasks done

Improve coverage where it's possible #546

brunobord opened this issue Sep 4, 2020 · 0 comments
Assignees
@brunobord
Labels
small improvement Small steps, but nice to have
Projects
Workalendar

Comments

@brunobord
Copy link
Member

brunobord commented Sep 4, 2020 •
edited

  • South Africa and the year 2001
  • Brazil: get_last_day_of_year_for_only_internal_bank_trans()
  • Canada (Nunavut shift)
  • Israel
  • Singapore
  • core (several lines)
  • Netherlands
  • Romania
  • New Zealand (two blocks)
  • astronomy.py
  • Russia
  • tests/__init__.py
  • tests/test_usa.py (several blocks, this is a known issue) won't fix
  • usa/core.py
  • usa/indiana.py
brunobord added a commit that referenced this issue Sep 4, 2020
@brunobord
Improve coverage of South Africa calendar
3cb7fec 
refs #546
@brunobord brunobord self-assigned this Sep 4, 2020
@brunobord brunobord added the small improvement Small steps, but nice to have label Sep 4, 2020
@brunobord brunobord added this to Warming up in Workalendar via automation Sep 4, 2020
@brunobord brunobord moved this from Warming up to Working in Workalendar Sep 4, 2020
@brunobord brunobord mentioned this issue Sep 4, 2020
Merged
2 tasks
brunobord added a commit that referenced this issue Sep 4, 2020
@brunobord
Improve coverage of Brazil calendar
f678aa8 
refs #546
@brunobord brunobord mentioned this issue Sep 4, 2020
Merged
2 tasks
brunobord added a commit that referenced this issue Sep 4, 2020
@brunobord
Improve coverage of Israel calendar
6cacd50 
refs #546

We had to include the year 2021, because it offered the case that was missing in the `get_hebrew_independence_day` method.
@brunobord brunobord mentioned this issue Sep 4, 2020
Merged
2 tasks
brunobord added a commit that referenced this issue Sep 11, 2020
@brunobord
Improve coverage of Singapore calendar
54d1b73 
Small refactor to trigger the KeyError a bit earlier.

refs #546
@brunobord brunobord mentioned this issue Sep 11, 2020
Merged
2 tasks
brunobord added a commit that referenced this issue Oct 9, 2020
@brunobord
Improve coverage of the core.py module
b52c139 
refs #546
@brunobord brunobord mentioned this issue Oct 9, 2020
Merged
2 tasks
brunobord added a commit that referenced this issue Oct 9, 2020
@brunobord
Improve coverage for the Netherlands calendar
04707d1 
Fixed the uncovered special case of Queen's Day when it falls on SUN.

refs #546
@brunobord brunobord mentioned this issue Oct 9, 2020
Merged
2 tasks
brunobord added a commit that referenced this issue Oct 9, 2020
@brunobord
Improve coverage for the Netherlands calendar
87f9f37 
Fixed the uncovered special case of Queen's Day when it falls on SUN.

refs #546
brunobord added a commit that referenced this issue Oct 9, 2020
@brunobord
Improve New Zealand test coverage
3bb1602 
refs #546
@brunobord brunobord mentioned this issue Oct 9, 2020
Merged
2 tasks
@brunobord brunobord mentioned this issue Jan 15, 2021
Closed
brunobord added a commit that referenced this issue Jan 15, 2021
@brunobord
Netherlands school holidays refactor
4dab5a8 
- Small fixes in Netherlands School calendars (#619).
- New method available in `core` module: `Calendar.get_iso_week_date()` to find the weekday X of the week number Y (#619).
- Improve Netherlands coverage (#546, #619).
brunobord added a commit that referenced this issue Jan 15, 2021
@brunobord
Netherlands school holidays refactor
93d621b 
- Small fixes in Netherlands School calendars (#619).
- New method available in `core` module: `Calendar.get_iso_week_date()` to find the weekday X of the week number Y (#619).
- Improve Netherlands coverage (#546, #619).
@brunobord brunobord mentioned this issue Jan 15, 2021
Merged
2 tasks
brunobord added a commit that referenced this issue Jan 15, 2021
@brunobord
Improve Russia calendar coverage
6871907 
This one is tricky: it's apparently a "coverage" issue related to the Python bytecode optimizer.

Ref: nedbat/coveragepy#198

Refs #546
brunobord added a commit that referenced this issue Jan 15, 2021
@brunobord
Improve Russia coverage
3cdced3 
Covering cases when we're fetching the Labour day label

refs #546
brunobord added a commit that referenced this issue Jan 22, 2021
@brunobord
Improve USA calendar coverage by removing the `get_washington_birthda…
0f4293c 
…y_december` method

refs #546
@brunobord brunobord mentioned this issue Jan 22, 2021
Merged
2 tasks
brunobord added a commit that referenced this issue Feb 5, 2021
@brunobord
Improve coverage for the astronomy.py module
4c0d498 
refs #546
brunobord added a commit that referenced this issue Feb 5, 2021
@brunobord
Improve coverage for the astronomy.py module
01674de 
refs #546
@brunobord brunobord mentioned this issue Feb 5, 2021
Merged
2 tasks
brunobord added a commit that referenced this issue Feb 5, 2021
@brunobord
Improve coverage for the tests/__init__.py module
7bf4d4f 
refs #546
@brunobord brunobord mentioned this issue Feb 5, 2021
Merged
2 tasks
Workalendar automation moved this from Working to Done Feb 5, 2021
brunobord added a commit that referenced this issue Feb 19, 2021
@brunobord
v15.0.0
47c81cd 
**Major changes**

- API: New method available in `core` module: `Calendar.get_iso_week_date()` to find the weekday X of the week number Y (#619).
- Requirements: Replace pytz with `(backports.)zoneinfo`, thx to @eumiro (#614)
- Doc: Documented the different (in)compatibilities due to the use of `zoneinfo` (#614).

**Minor changes**

*Bugfix*

- Small fixes in Netherlands School calendars (#619).
- Temporary downgrade of `pyupgrade` to fix the `pyup_dirs`.

*Improving test coverage*

- Improve Netherlands coverage (#546, #619).
- Improve Russia coverage (#546).
- Improve USA calendar coverage by removing a method that wasn't used anyways (`get_washington_birthday_december()`). The method is implemented in both Indiana and Georgia State calendars, and is specific for each state, even if they look very similar (#546).
- Improve the `astronomy.py` module coverage (#546).
- Improve coverage for the `tests/__init__.py` module (#546). *Note:* system-dependant test branch (if Windows) won't be counted for coverage.
@brunobord brunobord mentioned this issue Feb 19, 2021
Merged
14 tasks
brunobord added a commit that referenced this issue Feb 19, 2021
@brunobord
v15.0.0
2dc925c 
**Major changes**

- API: New method available in `core` module: `Calendar.get_iso_week_date()` to find the weekday X of the week number Y (#619).
- Requirements: Replace pytz with `(backports.)zoneinfo`, thx to @eumiro (#614)
- Doc: Documented the different (in)compatibilities due to the use of `zoneinfo` (#614).

**Minor changes**

*Bugfixes*

- Small fixes in Netherlands School calendars (#619).
- Temporary downgrade of `pyupgrade` to fix the `pyup_dirs`.

*Improving test coverage*

- Improve Netherlands coverage (#546, #619).
- Improve Russia coverage (#546).
- Improve USA calendar coverage by removing a method that wasn't used anyways (`get_washington_birthday_december()`). The method is implemented in both Indiana and Georgia State calendars, and is specific for each state, even if they look very similar (#546).
- Improve the `astronomy.py` module coverage (#546).
- Improve coverage for the `tests/__init__.py` module (#546). *Note:* system-dependant test branch (if Windows) won't be counted for coverage.
brunobord added a commit that referenced this issue Feb 19, 2021
@brunobord
v15.0.0
00e2bed 
**Major changes**

- API: New method available in `core` module: `Calendar.get_iso_week_date()` to find the weekday X of the week number Y (#619).
- Requirements: Replace pytz with `(backports.)zoneinfo`, thx to @eumiro (#614)
- Doc: Documented the different (in)compatibilities due to the use of `zoneinfo` (#614).

**Minor changes**

*Bugfixes*

- Small fixes in Netherlands School calendars (#619).
- Temporary downgrade of `pyupgrade` to fix the `pyup_dirs`.

*Improving test coverage*

- Improve Netherlands coverage (#546, #619).
- Improve Russia coverage (#546).
- Improve USA calendar coverage by removing a method that wasn't used anyways (`get_washington_birthday_december()`). The method is implemented in both Indiana and Georgia State calendars, and is specific for each state, even if they look very similar (#546).
- Improve the `astronomy.py` module coverage (#546).
- Improve coverage for the `tests/__init__.py` module (#546). *Note:* system-dependant test branch (if Windows) won't be counted for coverage.
@dependabot dependabot bot mentioned this issue Mar 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brunobord brunobord

Labels
small improvement Small steps, but nice to have
Projects
Workalendar
  
Done/Closed/Published
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brunobord