Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netherlands school holidays refactor #619

Closed
brunobord opened this issue Jan 15, 2021 · 1 comment
Closed

Netherlands school holidays refactor #619

brunobord opened this issue Jan 15, 2021 · 1 comment
Labels
small improvement Small steps, but nice to have
Projects
Workalendar

Comments

@brunobord
Copy link
Member

brunobord commented Jan 15, 2021 •
edited

Things need to be a bit cleaned up / tidied up / refactored

  • There's an opportunity to implement a testable function to find the beginning of the week X. The function is available in Python 3.7 and is backported in the Netherlands calendar, but it's spread out in several classes, so I think it would be worth centralize this mechanic in the core module.
  • Test coverage has decreased and it can be improved (Improve coverage where it's possible #546)
  • I've seen a few lines to remove in the test classes.
@brunobord brunobord added this to Warming up in Workalendar via automation Jan 15, 2021
@brunobord brunobord moved this from Warming up to Working in Workalendar Jan 15, 2021
@brunobord brunobord added the small improvement Small steps, but nice to have label Jan 15, 2021
brunobord added a commit that referenced this issue Jan 15, 2021
@brunobord
Netherlands school holidays refactor
4dab5a8 
- Small fixes in Netherlands School calendars (#619).
- New method available in `core` module: `Calendar.get_iso_week_date()` to find the weekday X of the week number Y (#619).
- Improve Netherlands coverage (#546, #619).
brunobord added a commit that referenced this issue Jan 15, 2021
@brunobord
Netherlands school holidays refactor
93d621b 
- Small fixes in Netherlands School calendars (#619).
- New method available in `core` module: `Calendar.get_iso_week_date()` to find the weekday X of the week number Y (#619).
- Improve Netherlands coverage (#546, #619).
@brunobord brunobord mentioned this issue Jan 15, 2021
Merged
2 tasks
@brunobord
Copy link
Member Author

closed by #620

Workalendar automation moved this from Working to Done Jan 15, 2021
brunobord added a commit that referenced this issue Feb 19, 2021
@brunobord
v15.0.0
47c81cd 
**Major changes**

- API: New method available in `core` module: `Calendar.get_iso_week_date()` to find the weekday X of the week number Y (#619).
- Requirements: Replace pytz with `(backports.)zoneinfo`, thx to @eumiro (#614)
- Doc: Documented the different (in)compatibilities due to the use of `zoneinfo` (#614).

**Minor changes**

*Bugfix*

- Small fixes in Netherlands School calendars (#619).
- Temporary downgrade of `pyupgrade` to fix the `pyup_dirs`.

*Improving test coverage*

- Improve Netherlands coverage (#546, #619).
- Improve Russia coverage (#546).
- Improve USA calendar coverage by removing a method that wasn't used anyways (`get_washington_birthday_december()`). The method is implemented in both Indiana and Georgia State calendars, and is specific for each state, even if they look very similar (#546).
- Improve the `astronomy.py` module coverage (#546).
- Improve coverage for the `tests/__init__.py` module (#546). *Note:* system-dependant test branch (if Windows) won't be counted for coverage.
@brunobord brunobord mentioned this issue Feb 19, 2021
Merged
14 tasks
brunobord added a commit that referenced this issue Feb 19, 2021
@brunobord
v15.0.0
2dc925c 
**Major changes**

- API: New method available in `core` module: `Calendar.get_iso_week_date()` to find the weekday X of the week number Y (#619).
- Requirements: Replace pytz with `(backports.)zoneinfo`, thx to @eumiro (#614)
- Doc: Documented the different (in)compatibilities due to the use of `zoneinfo` (#614).

**Minor changes**

*Bugfixes*

- Small fixes in Netherlands School calendars (#619).
- Temporary downgrade of `pyupgrade` to fix the `pyup_dirs`.

*Improving test coverage*

- Improve Netherlands coverage (#546, #619).
- Improve Russia coverage (#546).
- Improve USA calendar coverage by removing a method that wasn't used anyways (`get_washington_birthday_december()`). The method is implemented in both Indiana and Georgia State calendars, and is specific for each state, even if they look very similar (#546).
- Improve the `astronomy.py` module coverage (#546).
- Improve coverage for the `tests/__init__.py` module (#546). *Note:* system-dependant test branch (if Windows) won't be counted for coverage.
brunobord added a commit that referenced this issue Feb 19, 2021
@brunobord
v15.0.0
00e2bed 
**Major changes**

- API: New method available in `core` module: `Calendar.get_iso_week_date()` to find the weekday X of the week number Y (#619).
- Requirements: Replace pytz with `(backports.)zoneinfo`, thx to @eumiro (#614)
- Doc: Documented the different (in)compatibilities due to the use of `zoneinfo` (#614).

**Minor changes**

*Bugfixes*

- Small fixes in Netherlands School calendars (#619).
- Temporary downgrade of `pyupgrade` to fix the `pyup_dirs`.

*Improving test coverage*

- Improve Netherlands coverage (#546, #619).
- Improve Russia coverage (#546).
- Improve USA calendar coverage by removing a method that wasn't used anyways (`get_washington_birthday_december()`). The method is implemented in both Indiana and Georgia State calendars, and is specific for each state, even if they look very similar (#546).
- Improve the `astronomy.py` module coverage (#546).
- Improve coverage for the `tests/__init__.py` module (#546). *Note:* system-dependant test branch (if Windows) won't be counted for coverage.
@dependabot dependabot bot mentioned this issue Mar 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
small improvement Small steps, but nice to have
Projects
Workalendar
  
Done/Closed/Published
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brunobord