Replace pytz with zoneinfo (backports.zoneinfo for Python 3.6–3.8) #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewjoachim
reviewed
Jan 8, 2021
setup.cfg
Outdated
| @@ -30,7 +30,7 @@ install_requires = | |||
| skyfield-data | |||
| python-dateutil | |||
| lunardate | |||
| pytz | |||
| backports.zoneinfo | |||
There was a problem hiding this comment.
I wonder if it's worth making it a dependency only when needed or it this will create more problems than it will solve
There was a problem hiding this comment.
That's a great hint. So something like
backports.zoneinfo;python_version<"3.9"
There was a problem hiding this comment.
can you enlight me here? Even if pytz is not in the stdlib, it works, doesn't it? And if you want to support Python 3.6 to 3.9, it looks like the only Python version where zoneinfo is in the stdlib is the 3.9, so it's not "widely standard".
In a word or two, why would we have to switch to zoneinfo? Is there a definitive advantage to it?
There was a problem hiding this comment.
@ewjoachim I updated it and repushed.
There was a problem hiding this comment.
@brunobord zoneinfo uses your system's tz database, while pytz sometimes brings its own.
2 tasks
brunobord
added a commit
that referenced
this pull request
Feb 19, 2021
**Major changes** - API: New method available in `core` module: `Calendar.get_iso_week_date()` to find the weekday X of the week number Y (#619). - Requirements: Replace pytz with `(backports.)zoneinfo`, thx to @eumiro (#614) - Doc: Documented the different (in)compatibilities due to the use of `zoneinfo` (#614). **Minor changes** *Bugfix* - Small fixes in Netherlands School calendars (#619). - Temporary downgrade of `pyupgrade` to fix the `pyup_dirs`. *Improving test coverage* - Improve Netherlands coverage (#546, #619). - Improve Russia coverage (#546). - Improve USA calendar coverage by removing a method that wasn't used anyways (`get_washington_birthday_december()`). The method is implemented in both Indiana and Georgia State calendars, and is specific for each state, even if they look very similar (#546). - Improve the `astronomy.py` module coverage (#546). - Improve coverage for the `tests/__init__.py` module (#546). *Note:* system-dependant test branch (if Windows) won't be counted for coverage.
brunobord
added a commit
that referenced
this pull request
Feb 19, 2021
**Major changes** - API: New method available in `core` module: `Calendar.get_iso_week_date()` to find the weekday X of the week number Y (#619). - Requirements: Replace pytz with `(backports.)zoneinfo`, thx to @eumiro (#614) - Doc: Documented the different (in)compatibilities due to the use of `zoneinfo` (#614). **Minor changes** *Bugfixes* - Small fixes in Netherlands School calendars (#619). - Temporary downgrade of `pyupgrade` to fix the `pyup_dirs`. *Improving test coverage* - Improve Netherlands coverage (#546, #619). - Improve Russia coverage (#546). - Improve USA calendar coverage by removing a method that wasn't used anyways (`get_washington_birthday_december()`). The method is implemented in both Indiana and Georgia State calendars, and is specific for each state, even if they look very similar (#546). - Improve the `astronomy.py` module coverage (#546). - Improve coverage for the `tests/__init__.py` module (#546). *Note:* system-dependant test branch (if Windows) won't be counted for coverage.
brunobord
added a commit
that referenced
this pull request
Feb 19, 2021
**Major changes** - API: New method available in `core` module: `Calendar.get_iso_week_date()` to find the weekday X of the week number Y (#619). - Requirements: Replace pytz with `(backports.)zoneinfo`, thx to @eumiro (#614) - Doc: Documented the different (in)compatibilities due to the use of `zoneinfo` (#614). **Minor changes** *Bugfixes* - Small fixes in Netherlands School calendars (#619). - Temporary downgrade of `pyupgrade` to fix the `pyup_dirs`. *Improving test coverage* - Improve Netherlands coverage (#546, #619). - Improve Russia coverage (#546). - Improve USA calendar coverage by removing a method that wasn't used anyways (`get_washington_birthday_december()`). The method is implemented in both Indiana and Georgia State calendars, and is specific for each state, even if they look very similar (#546). - Improve the `astronomy.py` module coverage (#546). - Improve coverage for the `tests/__init__.py` module (#546). *Note:* system-dependant test branch (if Windows) won't be counted for coverage.
|
the new requirement handling of timezone libraries is now in Workalendar 15.0.0. Happy upgrading to anyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.9 brings
zoneinfoin its stdlib and it is also distributed asbackports.zoneinfofor Python 3.6–3.8. Replacepytzwith it.