Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't shell out to bundler to get gem path #192

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Don't shell out to bundler to get gem path #192

merged 1 commit into from
Oct 31, 2019

Conversation

bencrouse
Copy link
Contributor

This can cause problems if bundler outputs warnings/errors. There's a safe way to do it in Ruby, so use that instead.

Fixes #191

Don't shell out to bundler to get gem path
c587a18 
This can cause problems if bundler outputs warnings/errors. There's a safe way to do it in Ruby, so use that instead.

Fixes #191
@bencrouse bencrouse added this to the v3.4.19 milestone Oct 28, 2019
@bencrouse bencrouse mentioned this pull request Oct 28, 2019
Closed
@bencrouse bencrouse modified the milestones: v3.4.19, v3.4.21 Oct 30, 2019
@bencrouse bencrouse merged commit 721dbbb into v3.4-stable Oct 31, 2019
@bencrouse bencrouse deleted the fix-gem-path-in-workarea-services branch October 31, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tubbo tubbo tubbo approved these changes

@mttdffy mttdffy mttdffy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4.21
Development

Successfully merging this pull request may close these issues.
3 participants
@bencrouse @tubbo @mttdffy