Fix Overwriting CORS Rules for S3 Direct Uploads #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tubbo
force-pushed
the
WORKAREA-209-fix-cors-overwriting
branch
from
042b0ef
to
2aeef43
Compare
bencrouse
approved these changes
Feb 12, 2020
bencrouse
suggested changes
Feb 12, 2020
Workarea previously replaced the existing CORS configuration on the S3 bucket used for storing direct uploads with its own, which caused issues for environments that share an S3 bucket between servers (such as ad-hoc demo servers or low-traffic "all-in-one" instances). Instead of replacing the entire configuration, Workarea now reads the existing allowed hosts configuration and appends its own onto the end, preserving the configuration that previously existed. This should address the problem wherein if another server attempts a direct upload, it can revoke the access from previous servers to upload to the S3 bucket, since they were no longer in the CORS configuration. WORKAREA-209
tubbo
force-pushed
the
WORKAREA-209-fix-cors-overwriting
branch
from
2aeef43
to
b1ee60c
Compare
|
whoops, forgot to mock it out in the system test. should be OK now. |
bencrouse
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workarea previously replaced the existing CORS configuration on the S3
bucket used for storing direct uploads with its own, which caused issues
for environments that share an S3 bucket between servers (such as ad-hoc
demo servers or low-traffic "all-in-one" instances). Instead of
replacing the entire configuration, Workarea now reads the existing
allowed hosts configuration and appends its own onto the end, preserving
the configuration that previously existed. This should address the
problem wherein if another server attempts a direct upload, it can
revoke the access from previous servers to upload to the S3 bucket,
since they were no longer in the CORS configuration.