-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workbench fails on large Blueprint files #240
Comments
For reference
|
Also additionally, if you take out any of the pages 1, 2 , or 3. as far as I can tell it does actually work again. |
The error is actually this:
The timeout is a consequence. It looks like for some reason - we can't read a lsp message over 81838 bytes If I make the Blueprint larger - I get a higher I don't know yet if it's a problem with Workbench or Blueprint language server. https://docs.gtk.org/gio/method.InputStream.read_bytes_async.html
|
Yes. it is fixed now. I even put in more things for other pages making it almost 1100 lines and its still fine. I don't think speed matters that much, as long as it works at all. Edit: I played around with it more/kept building my ideas for my app. and sometimes it still comes up with the same error, but with longer timeout. but then seems like it keeps working anyways. |
The CLI appears to be twice as fast than LSP for this large file. LSP: re.sonny.Workbench.Devel-Message: 12:25:11.126: compile: 1230.009 ms CLI: sonny@porygon ~/P/Workbench (main)> time blueprint-compiler compile test.blp
...
________________________________________________________
Executed in 630.91 millis fish external
usr time 560.81 millis 0.00 micros 560.81 millis
sys time 58.74 millis 653.00 micros 58.08 millis According to quick and lightweight Workbench profiling - the overhead is in blueprint language server re.sonny.Workbench.Devel-Message: 12:28:05.282: read: 0.273 ms
re.sonny.Workbench.Devel-Message: 12:28:05.282: decode: 0.140 ms
re.sonny.Workbench.Devel-Message: 12:28:05.282: parse: 0.121 ms |
@jameswestman solved it and lsp is now faster than cli for this large blp https://gitlab.gnome.org/jwestman/blueprint-compiler/-/merge_requests/97 Thanks! |
James made it 3x times faster on large files See #240 (comment)
James made it 3x times faster on large files See workbenchdev#240 (comment)
James made it 3x times faster on large files See workbenchdev#240 (comment)
When pasting my Main Window Blueprint into the UI field in Workbench devel. (with Code and Style being empty).
It errors out saying TimeoutError. (I need to actually scroll up to see the error message).
As well as the preview section being completely empty.
The text was updated successfully, but these errors were encountered: