Support root property updates for JS #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
commented
Jun 12, 2022
| } | ||
| adoptChild(object_preview, object_root); |
There was a problem hiding this comment.
since child and content are properties, and we now update all properties, we don't need this anymore
sonnyp
commented
Jun 12, 2022
| title: "My App"; | ||
| description: "My App is awesome"; | ||
| vexpand: true; | ||
| icon-name: "applications-science-symbolic"; |
There was a problem hiding this comment.
I prefer using a "standard" icon for this demo
sonnyp
commented
Jun 12, 2022
| @@ -1,47 +1,39 @@ | |||
| using Gtk 4.0; | |||
| using Adw 1; | |||
|
|
|||
| Adw.ApplicationWindow window { | |||
| Gtk.ApplicationWindow window { | |||
There was a problem hiding this comment.
no reason to use Adw.Window / Adw.ApplicationWindow if we don't want a freeform window
sonnyp
commented
Jun 12, 2022
| icon-name: "open-menu-symbolic"; | ||
| primary: true; | ||
| } | ||
| title: "My App"; |
There was a problem hiding this comment.
updating a root property, such as title now works as expected
sonnyp
commented
Jun 12, 2022
| primary: true; | ||
| } | ||
| title: "My App"; | ||
| titlebar: Gtk.HeaderBar { |
There was a problem hiding this comment.
same for widget properties of course, try removing it for example
|
@lw64 could you test/review this and once satisfied—implement the same algorithm on the Vala side in this branch ? |
This comment was marked as resolved.
This comment was marked as resolved.
sonnyp
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60
Needs the Vala equivalent and ready to go (as far as I can tell)