New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
library: Add Header Bar entry #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took me so long to get to this!
This looks really great, I don't think there's much to nitpick about here 🙂
Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com>
No worries at all :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We can merge if @sonnyp agrees
05f69f1
to
55e450f
Compare
This demonstrates how to use the objects/properties but with Workbench we're also trying to encourage developers on how to use them properly. Whatever people copy paste from Workbench should be correct and in accordance with the HIG / GNOME practices. I think there are a couple of issues with this entry:
However if we fix all of these, the entry becomes over-simplified. What might be interesting is to show how header bars can be used in different ways depending on content and type of window. @bertob wdyt? |
Ok so I talked with Tobias. And since other library entries will feature hearbars such as the existing Window and and future ToolbarView entries we will make sure that searching for "header bar" shows all the relevant entries. |
I could not find some of those icons from that example in the library so I chose to keep the previous ones. I made the other changes you requested. |
Adds Header Bar entry.
Issue workbenchdev/demos#3