library: Adds ColorPicker Demo #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
requested changes
Jun 14, 2023
SoNiC-HeRE
force-pushed
the
sonic/colorpicker
branch
from
1959adb
to
16db4a0
Compare
sonnyp
requested changes
Jun 15, 2023
| using Adw 1; | ||
|
|
||
| Adw.StatusPage { | ||
| title: "Color Picker"; |
There was a problem hiding this comment.
Suggested change
| title: "Color Picker"; | |
| title: _("Color Picker"); |
| label: _("Select Color"); | ||
| margin-bottom: 42; | ||
| halign: center; | ||
| styles ["suggested-action"] |
There was a problem hiding this comment.
Suggested change
| styles ["suggested-action"] | |
| styles ["suggested-action", "pill"] |
| } | ||
| } | ||
|
|
||
| button.connect("clicked", pickColor); |
There was a problem hiding this comment.
Similar to #330 (comment)
Remove the try/catch, rename and do
Suggested change
| button.connect("clicked", pickColor); | |
| button.connect("clicked", () => { | |
| onClicked().catch(logError); | |
| }); |
|
|
||
| async function pickColor() { | ||
| try { | ||
| const color = await portal.pick_color(parent, null); |
There was a problem hiding this comment.
the result of pick_color isn't really a color, I would naming the return value result instead and move the comment there
Suggested change
| const color = await portal.pick_color(parent, null); | |
| // result is a GVariant of the form (ddd), containing red, green and blue components in the range [0,1] | |
| const result = await portal.pick_color(parent, null); |
Comment on lines
17
to
20
| const colorInfo = color.print(false); | ||
|
|
||
| // The picked color is a GVariant of the form (ddd), containing red, green and blue components in the range [0,1]. | ||
| console.log(`Selected Color is: ${colorInfo}`); |
There was a problem hiding this comment.
wdyt we create a rgba color with https://docs.gtk.org/gdk4/struct.RGBA.html and then use color.to_string() ?
similar to the Color Dialog entry
You can read rgb from result using const [r,g,b] = result.deepUnpack()
|
Made the following changes:
|
* libary: Add SpinButton entry * Spin Button: Add link to tutorial * Spin Button: Changes from review * Spin Button: Translated strings * Spin Button: Add comments for clarity
* library: Add AdwBanner entry * Banner: Translate strings
sonnyp
pushed a commit
that referenced
this pull request
Jun 20, 2023
sonnyp
pushed a commit
to SoNiC-HeRE/Workbench
that referenced
this pull request
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.from.2023-06-14.11-47-15.webm
Closes #334