Port 'Map' demo to Python #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theCapypara
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Thanks! I removed the type_ensure since that will be added in workbenchdev/Workbench#884
sonnyp
pushed a commit
to workbenchdev/Workbench
that referenced
this pull request
Feb 16, 2024
Hofer-Julian
pushed a commit
to workbenchdev/Workbench
that referenced
this pull request
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a
GObject.type_ensure(Shumate.SimpleMap)in the code, which would be better done in Workbench's Python module. Otherwise the demo works fine. I followed the Javascript implementation.