Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Previewer: Initialize WebView #879

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Python Previewer: Initialize WebView #879

merged 2 commits into from
Feb 11, 2024

Conversation

theCapypara
Copy link
Contributor

WebView has no init function, which is odd. This might be an upstream bug after all, but I'm really not sure.
This works at least and will continue to work, even if this is "fixed" upstream.

@sonnyp
Copy link
Contributor

sonnyp commented Feb 9, 2024

I think I'd like to use type_ensure for all dependencies and in every lang support.

WDYT?

@theCapypara
Copy link
Contributor Author

Sure! Although the question is probably, what types should we ensure then? For GtkSource for example it's probably simple Gtk.SourceView.

@sonnyp
Copy link
Contributor

sonnyp commented Feb 10, 2024

Hmm does init usually registers all objects? Maybe we do want to use that instead when possible.

There is ensure_types in previewer.vala

@theCapypara
Copy link
Contributor Author

It's probably still a bit overkill to ensure all types of a library or even a big subset for some of them. I would asume all the libs that have an init to also make sure the types are properly registered, so personally I think using ensure_type(s) only for libs without an init is probably fine.

@sonnyp
Copy link
Contributor

sonnyp commented Feb 11, 2024

I think using ensure_type(s) only for libs without an init is probably fine.

That's what I had in mind 👍
probably my comment wasn't very clear sorry

@sonnyp sonnyp merged commit deb048d into main Feb 11, 2024
1 check passed
@sonnyp sonnyp deleted the capypara/fix-py-webview branch February 11, 2024 11:57
@sonnyp
Copy link
Contributor

sonnyp commented Feb 11, 2024

I'll follow up to harmonize across languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants