Navbar Language Switch #380
Conversation
|
Any chance you can make this flag icons? I find that it's quite large and doesn't looks the best. |
Sure, but what flag should I use for English language? I actually thought of this idea, but then I got stuck on whether the UK or the US flag would fit best 😅 Also, should I use emojis (🇬🇧 | 🇯🇵) (they show up as "GB" and "JP" on Windows) or actual icons? |
|
Hey both, why don't we just use the (🇬🇧 | 🇯🇵) flags for now and just deploy this? We can always amend later. Wanna make that edit, @Prid13, and issue the PR? I guess I kind of agree with Zain on the usability issues by selecting language automatically based on location. |
Old icons had MIT license. New icons are taken from Wikipedia, which uses Creative Commons license, and the flags are public domain as it says on Wikipedia.
Wasn't possible to add images/icons, so had to opt for emoji flags 😅 Non-existent in Windows though
|
Done :) On Windows the flags won't show up:
But they will on mobile. Something like this:
|
Opted for "English" (instead of "EN").
It's a dropdown :)
Mobile