Refactor Buffer usage #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #964
PaulAsjes
approved these changes
Feb 19, 2024
src/webhooks/webhooks.ts
Outdated
| @@ -107,8 +108,9 @@ export class Webhooks { | |||
| } | |||
|
|
|||
| async secureCompare(stringA: string, stringB: string): Promise<boolean> { | |||
| const bufferA = Buffer.from(stringA); | |||
| const bufferB = Buffer.from(stringB); | |||
| const encoder = new TextEncoder(); | |||
There was a problem hiding this comment.
Nit, but maybe this should be a class variable rather than being reinitialised.
There was a problem hiding this comment.
Good idea, done in b0a8840
PaulAsjes
approved these changes
Feb 19, 2024
Merged
benoitgrelard
added a commit
that referenced
this pull request
Feb 19, 2024
## Description This will include #965 and #966 ## Documentation Does this require changes to the WorkOS Docs? E.g. the [API Reference](https://workos.com/docs/reference) or code snippets need updates. ``` [ ] Yes ``` If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #964
There was a leftover usage of Node's
BufferAPI.I have converted it to use the web platform's
TextEncoderAPIs instead.I wonder if there's an ESLint plugin that could be used to lint for usages of APIs incompatible with cloudflare workers/edge runtime as it seems easy to let something through without thoroughly testing every single API call. A quick google search didn't bring much up so far.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.