Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null body #966

Merged
merged 3 commits into from Feb 19, 2024
Merged

Allow null body #966

merged 3 commits into from Feb 19, 2024

Conversation

benoitgrelard
Copy link
Contributor

Description

This is follow-up from the issue raised in #963

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

Copy link
Contributor

@PaulAsjes PaulAsjes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker for this PR, but we should add tests for all the files in the /utils directory.

@benoitgrelard
Copy link
Contributor Author

benoitgrelard commented Feb 19, 2024

Not a blocker for this PR, but we should add tests for all the files in the /utils directory.

I've added a regression test in the workos test suite for now.

@benoitgrelard benoitgrelard merged commit b523a47 into main Feb 19, 2024
1 check passed
@benoitgrelard benoitgrelard deleted the fix-null-body branch February 19, 2024 11:45
@benoitgrelard benoitgrelard mentioned this pull request Feb 19, 2024
benoitgrelard added a commit that referenced this pull request Feb 19, 2024
## Description

This will include #965 and #966 

## Documentation

Does this require changes to the WorkOS Docs? E.g. the [API
Reference](https://workos.com/docs/reference) or code snippets need
updates.

```
[ ] Yes
```

If yes, link a related docs PR and add a docs maintainer as a reviewer.
Their approval is required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants