WIP: Add Filter to URL #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sery0ga
reviewed
Nov 22, 2019
| */ | ||
| private filterEvents(e: Event) { | ||
| public filterEvents(e?: Event) { |
There was a problem hiding this comment.
Могу ошибаться, но вроде бы для публичных методов служебное слово везде опускается.
There was a problem hiding this comment.
Вот я тут не очень понял этого, можешь пояснить?
There was a problem hiding this comment.
:) да, криво написал. Я везде опускаю служебное слово public. Это единственное место, где публичный метод явно объявлен публичным.
|
|
||
| private parseSearchPath(type: string, value: string): boolean { | ||
| const createURL = this.generateUrl(); | ||
| const findValue = createURL.searchParams.getAll(type); |
There was a problem hiding this comment.
searchParams поддерживаются в IE?
There was a problem hiding this comment.
Нет не поддерживается, надо бы polyfill заюзать!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.