Surround npm variable with double quotes to fix spaced filepaths. Fix… #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Having also experienced the underlying issue, I applied this patch and successfully tested / completed how-to-npm on Win8 from the NodeJS command prompt. Thanks @cakenggt |
|
@ashleygwilliams I double checked this solution and it is correct and does not seem to break mac os either, so it should also be fine for linux. closes a bunch of tickets. |
|
LGTM, merging! Thank you @cakenggt! |
This was referenced Mar 3, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for ticket #56.