Fix display issues in README with tables and logo #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Website fix (#2) * Added class: table-container * Added .table-container to CSS file * Added #contributors * Added #contributors to css file. Added min-width property to #contributors. * Removed .table-containers from #contributors * Revert * Removed class table-container from contributors * Changing td in #contributors * Adding .table-container * Website fix 3 (#3) * Added class: table-container * Added .table-container to CSS file * Added #contributors * Added #contributors to css file. Added min-width property to #contributors. * Removed .table-containers from #contributors * Revert * Removed class table-container from contributors * Changing td in #contributors * Adding .table-container * Added final project table to #table-container
sglavoie
approved these changes
Apr 23, 2021
| @@ -167,3 +167,12 @@ pre code { | |||
| display: inline-block; | |||
| box-shadow: none; | |||
| } | |||
| #contributors td{ | |||
| min-width: 130px; | |||
There was a problem hiding this comment.
I think that was a great solution to make it look nice on mobile. 🙂
There was a problem hiding this comment.
Thanks @sglavoie 😅
sglavoie
changed the title
|
@all-contributors please add @kaushikpadmanaban for a11y, bug, code, design |
|
I've put up a pull request to add @kaushikpadmanaban! 🎉 |
|
Looks good now 😁 Thanks @kaushikpadmanaban |
|
You're welcome @kaushikpadmanaban! It is our duty to honour the meaning of the badge. 😁
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Banner unresponsive to changing screen size
Bug discussed here
This commit:
such as horizontal scrolling.
(This ensures that all profiles inside appear in orderly fashion, instead of the ones
in the centre being squashed to adjust to screen size.
As a result, the entire homepage is now mobile-friendly, and can accommodate screens as low as 320px wide.
Also, the contributors tab looks a lot better than GitHub's own rendering of the README.md.