Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GitHub page rendered site layout problem on phone #196

Closed
ankush opened this issue Apr 21, 2021 · 4 comments
Closed

[BUG] GitHub page rendered site layout problem on phone #196

ankush opened this issue Apr 21, 2021 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers status: completed Issues that no longer require attention as they are solved

Comments

@ankush
Copy link
Contributor

ankush commented Apr 21, 2021

Banner image could be made responsive to avoid waste of screen space.

Screenshot_20210421-220733.png

@ankush ankush added bug Something isn't working good first issue Good for newcomers labels Apr 21, 2021
@sglavoie
Copy link
Member

I believe this was not the intended result. Thank you and good catch. 😄

@sglavoie
Copy link
Member

sglavoie commented Apr 22, 2021

Adding to this, there will also be a need to drop the width occupied by the contributors' table. Screenshot showing how it will look once the banner image is fixed (varies slightly depending on the device):

image

So that means having slightly smaller avatars (to keep some margins around) and 3 columns instead of 4 I guess.

Edit: as per @kaushikpadmanaban's comment, I do think that we should go for a more responsive solution for the contributors' table, maybe by allowing horizontal overflow requiring scrolling on mobile. Otherwise, It looks like we would need to go for another way of adding the contributors on the page since allcontributors does not seem to provide a straightforward way of integrating a responsive table (as pointed out in all-contributors/all-contributors#29).

@kaushikpadmanaban
Copy link
Contributor

We could make a carousel for the contributors, and display some information about them. But that is a project on its own, and is wildly beyond the possibilities provided by Jekyll and the allcontributors configuration.

sglavoie pushed a commit that referenced this issue Apr 23, 2021
* Fix bug mentioned in #196
* Added classes and ID #contributors to target the contributors table.
* Adjusted properties to make the logo and tables responsive.
@sglavoie
Copy link
Member

I agree @kaushikpadmanaban. Let's not go too far into this... unless you want to 😁.


FIXED: Closing since this issue was fixed in #198 🎉

@sglavoie sglavoie added the status: completed Issues that no longer require attention as they are solved label Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers status: completed Issues that no longer require attention as they are solved
Projects
None yet
Development

No branches or pull requests

3 participants