Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tables for Certificates to Kingdom Spanner schema. #81

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

SanjayVas
Copy link
Member

@SanjayVas SanjayVas commented May 27, 2021

This change is Reviewable

@SanjayVas
Copy link
Member Author

SanjayVas commented May 27, 2021

This is intended to be merged into main after the base PR #83.

Base automatically changed from sanjayvas-certificates to main May 27, 2021 00:25
Copy link
Contributor

@efoxepstein efoxepstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/measurement.sdl, line 20 at r1 (raw file):

--   Root
--   ├── Certificates
--   ├── DataProviders

Does it make any sense to split each root table into its own SDL file?

I'm just thinking it's a little arbitrary that it lives here and not with ModelProviders with the panel match tables.

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/measurement.sdl, line 20 at r1 (raw file):

Previously, efoxepstein (Eli Fox-Epstein) wrote…

Does it make any sense to split each root table into its own SDL file?

I'm just thinking it's a little arbitrary that it lives here and not with ModelProviders with the panel match tables.

Let me give it a shot and make sure the ordering works out.

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @efoxepstein)


src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/measurement.sdl, line 20 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Let me give it a shot and make sure the ordering works out.

So I was surprised that nothing broke ordering-wise, and then I realized it's because we were stripping all the FK constraints out when processing the SDL file. I created #83 to address that. The upshot is that this would require more granular splitting in order to get all the tables and references in the right order (meaning just splitting by root table would be insufficient).

@SanjayVas SanjayVas changed the base branch from main to sanjayvas-schema-constraint May 27, 2021 21:55
Copy link
Contributor

@efoxepstein efoxepstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas force-pushed the sanjayvas-schema-constraint branch from 839b71a to 61a892b Compare June 1, 2021 17:31
Base automatically changed from sanjayvas-schema-constraint to main June 1, 2021 17:37
Copy link
Contributor

@efoxepstein efoxepstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corbantek, @oliver-amzn, and @zachcwc)

Copy link

@zachcwc zachcwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corbantek and @oliver-amzn)

Copy link
Contributor

@corbantek corbantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @oliver-amzn)

@SanjayVas SanjayVas enabled auto-merge (squash) June 2, 2021 16:19
@SanjayVas SanjayVas merged commit 287c9ca into main Jun 2, 2021
@SanjayVas SanjayVas deleted the sanjayvas-certificates-sdl branch June 2, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants