-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tables for Certificates to Kingdom Spanner schema. #81
Conversation
This is intended to be merged into main after the base PR #83. |
e389ead
to
22b60ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/measurement.sdl, line 20 at r1 (raw file):
-- Root -- ├── Certificates -- ├── DataProviders
Does it make any sense to split each root table into its own SDL file?
I'm just thinking it's a little arbitrary that it lives here and not with ModelProviders with the panel match tables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/measurement.sdl, line 20 at r1 (raw file):
Previously, efoxepstein (Eli Fox-Epstein) wrote…
Does it make any sense to split each root table into its own SDL file?
I'm just thinking it's a little arbitrary that it lives here and not with ModelProviders with the panel match tables.
Let me give it a shot and make sure the ordering works out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @efoxepstein)
src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/measurement.sdl, line 20 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Let me give it a shot and make sure the ordering works out.
So I was surprised that nothing broke ordering-wise, and then I realized it's because we were stripping all the FK constraints out when processing the SDL file. I created #83 to address that. The upshot is that this would require more granular splitting in order to get all the tables and references in the right order (meaning just splitting by root table would be insufficient).
22b60ea
to
cf5601e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
839b71a
to
61a892b
Compare
cf5601e
to
36b46cd
Compare
36b46cd
to
8373520
Compare
8373520
to
55549f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @corbantek, @oliver-amzn, and @zachcwc)
6d63c64
to
450861a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @corbantek and @oliver-amzn)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @oliver-amzn)
450861a
to
6236c48
Compare
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)