Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define internal PublicKey message with corresponding Spanner tables. #88

Closed
wants to merge 1 commit into from

Conversation

SanjayVas
Copy link
Member

@SanjayVas SanjayVas commented Jun 2, 2021

This change is Reviewable

@SanjayVas
Copy link
Member Author

This is for #52. It is intended to be merged into main after the base PR #81.

Base automatically changed from sanjayvas-certificates-sdl to main June 2, 2021 16:23
Copy link
Contributor

@efoxepstein efoxepstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas
Copy link
Member Author

This is actually incorrect in its current form. The cardinality is incorrect: PublicKey is a singleton subresource of a MeasurementConsumer or DataProvider.

@SanjayVas SanjayVas marked this pull request as draft June 2, 2021 16:52
@SanjayVas SanjayVas closed this Jun 2, 2021
@SanjayVas SanjayVas deleted the sanjayvas-public-key branch June 2, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants